WordPress-Android icon indicating copy to clipboard operation
WordPress-Android copied to clipboard

Post List: Remove treeViewObserver

Open zwarm opened this issue 1 year ago • 3 comments

This PR may or may not be a good idea. It replaces setting a treeViewObserver with a custom UI textView for title and excerpt. The custom text view posts a runnable to perform the "set max line count" action after the layout pass is complete.

IMHO, I don't see that much of a visible difference. In fact, the list may be more janky. There are other things at play here that I haven't sussed out yet and happen both in this branch and the current production version: The list freezes at times when loading next page, the shimmer effect sometimes overlaps with text, at times the list of posts doesn't gather all the posts. Some of this may be due to how the "lists" action works, but I can't be certain as of yet.

Would love to hear thoughts. Thanks!


To Test:


Regression Notes

  1. Potential unintended areas of impact

    • TODO
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • TODO
  3. What automated tests I added (or what prevented me from doing so)

    • TODO

PR Submission Checklist:

  • [ ] I have completed the Regression Notes.
  • [ ] I have considered adding accessibility improvements for my changes.
  • [ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes Testing Checklist:

  • [ ] Portrait and landscape orientations.
  • [ ] Light and dark modes.
  • [ ] Fonts: Larger, smaller and bold text.
  • [ ] High contrast.
  • [ ] Talkback.
  • [ ] Languages with large words or with letters/accents not frequently used in English.
  • [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • [ ] Large and small screen sizes. (Tablet and smaller phones)
  • [ ] Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

zwarm avatar Dec 20 '23 20:12 zwarm

Fails
:no_entry_sign:

This PR is tagged with '[Status] Not Ready for Merge' label.

Generated by :no_entry_sign: dangerJS

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19829-3de20a5
Commit3de20a506274cad29e2b9e24da4e5c51abf4cea6
Direct Downloadwordpress-prototype-build-pr19829-3de20a5.apk
Note: Google Login is not supported on these builds.

wpmobilebot avatar Dec 20 '23 21:12 wpmobilebot

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19829-3de20a5
Commit3de20a506274cad29e2b9e24da4e5c51abf4cea6
Direct Downloadjetpack-prototype-build-pr19829-3de20a5.apk
Note: Google Login is not supported on these builds.

wpmobilebot avatar Dec 20 '23 21:12 wpmobilebot