WordPress-Android icon indicating copy to clipboard operation
WordPress-Android copied to clipboard

WIP: Custom app launcher icons

Open thomashorta opened this issue 2 years ago • 5 comments

Fixes #14476

Implement custom icons that can be selected by the user both for WordPress and Jetpack. This is still WIP as it will most likely be separated in smaller PRs, and it's also missing some unit tests and UI improvements, and still needs some minor issue fixes.

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • [ ] I have completed the Regression Notes.
  • [ ] I have considered adding accessibility improvements for my changes.
  • [ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

thomashorta avatar Mar 10 '23 21:03 thomashorta

Warnings
:warning: PR has more than 300 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by :no_entry_sign: dangerJS

Found 1 violations:

The PR caused the following dependency changes:

 \--- com.automattic:about:1.0.0
      +--- androidx.compose.ui:ui-tooling:1.0.5
-     |    \--- androidx.activity:activity-compose:1.3.1
-     |         +--- androidx.compose.runtime:runtime:1.0.1 -> 1.1.1 (*)
-     |         +--- androidx.compose.runtime:runtime-saveable:1.0.1 -> 1.1.1 (*)
-     |         +--- androidx.activity:activity-ktx:1.3.1 -> 1.5.1 (*)
-     |         +--- androidx.compose.ui:ui:1.0.1 -> 1.1.1 (*)
-     |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.21 -> 1.6.21 (*)
+     |    \--- androidx.activity:activity-compose:1.3.1 -> 1.5.1
+     |         +--- androidx.activity:activity-ktx:1.5.1 (*)
+     |         +--- androidx.compose.runtime:runtime:1.0.1 -> 1.1.1 (*)
+     |         +--- androidx.compose.runtime:runtime-saveable:1.0.1 -> 1.1.1 (*)
+     |         +--- androidx.compose.ui:ui:1.0.1 -> 1.1.1 (*)
+     |         +--- androidx.lifecycle:lifecycle-common-java8:2.5.1 (*)
+     |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
      \--- androidx.navigation:navigation-compose:2.4.0-beta02
-          \--- androidx.activity:activity-compose:1.3.1 (*)
+          \--- androidx.activity:activity-compose:1.3.1 -> 1.5.1 (*)
+\--- androidx.activity:activity-compose:1.5.1 (*)

Please review and act accordingly

<this is a auto generated comment from violation-comments-lib F7F8ASD8123FSDF>

<ACCUMULATED-VIOLATIONS>

wpmobilebot avatar Mar 10 '23 21:03 wpmobilebot

Jetpack📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr18084-2ad289d.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppJetpack
Build FlavorJalapeno
Build TypeDebug
Commit2ad289dc21be8de76dd3eeace8cb5664f663a93b
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

wpmobilebot avatar Mar 10 '23 21:03 wpmobilebot

WordPress📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr18084-2ad289d.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppWordPress
Build FlavorJalapeno
Build TypeDebug
Commit2ad289dc21be8de76dd3eeace8cb5664f663a93b
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

wpmobilebot avatar Mar 10 '23 21:03 wpmobilebot

Just a heads up this PR will stay in Draft for a bit as there are some things still needed for it to be ready for review and merge.

thomashorta avatar Mar 13 '23 17:03 thomashorta

This is fairly out-of-date – we might need it again in the future but closing for now.

jkmassel avatar Jul 09 '24 22:07 jkmassel