WordPress-Android icon indicating copy to clipboard operation
WordPress-Android copied to clipboard

Compiler Warnings as Errors - WordPress Module - Glide (BaseTarget & ViewTarget)

Open ParaskP7 opened this issue 3 years ago • 6 comments
trafficstars

Parent #17173

This issue is about resolving the Glide compile warnings, related to BaseTarget and ViewTarget, for the WordPress module, and possibly, for the lib modules as well.

PS: Some of those warnings are already deprecated (see here).


See Glide guide.


For more info see:

ParaskP7 avatar Oct 04 '22 13:10 ParaskP7

Fails
:no_entry_sign:

Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by :no_entry_sign: dangerJS

Hello @ParaskP7 👋, I want to work on this issue #17261 . Please assign this issue to me.

surajmaity1 avatar Oct 26 '22 05:10 surajmaity1

👋 @surajmaity1 and thank you so much for offering to contribute! 🥇

Please feel free to start working on this. As such, I'll go ahead and assign this task to you (and me). PS: I am assigning myself as well, as I'll be guiding you all the way, up until we collaboratively merge your solution to trunk.

Before you begin, make sure to at least read the following documentation:

  • README.md
    • Build Instructions (Step.2): You might notice that you would need to install npm. This is done for block editor related purposes (see gutenberg and gutenberg-mobile). The block editor is all React Native and as such this is a requirement for when working on it, especially for testing purposes. However, feel free to skip this step, that is, until you need it. PS: Most probably you won't be needing it for this task.
  • CONTRIBUTING.md
  • docs/coding-style.md

FYI: Note, depending on your solution, number of PRs, description on PRs, commit strategy, etc, I might ask you to improve on the quality and sometimes, even redo a PR. But, don't be afraid of it, I will only do that to help you out. Since this will be one of your first contribution to this repo, it is all part of the learning process, that is, until you become comfortable and aware about the ins-and-outs of how we work.

ParaskP7 avatar Oct 26 '22 07:10 ParaskP7

Thanks a lot, @ParaskP7 for assigning this issue to me.🤝

surajmaity1 avatar Oct 26 '22 10:10 surajmaity1

I would like to take this issue @ParaskP7 🚀.

Will get back in a next comment about how I will be taking this issue.

neeldoshii avatar Jun 09 '24 14:06 neeldoshii

👋 @neeldoshii and thank you so much for offering to contribute to this one as well! 🥇

Please feel free to start working on this. As such, I'll go ahead and re-assign this task to you now.

ParaskP7 avatar Jun 10 '24 07:06 ParaskP7

Closing this because its associated compile warnings project (paaHJt-3MK-p2) has been marked completed (paaHJt-3MK-p2#comment-6552) for some time already and it is unlikely that more work will be done on that front anytime soon.

ParaskP7 avatar Mar 11 '25 12:03 ParaskP7