WordPress-Android icon indicating copy to clipboard operation
WordPress-Android copied to clipboard

Fix dark mode issue on countries card

Open irfano opened this issue 3 years ago • 2 comments

Fixes #17111 This fixes the white background issue on the countries card in dark mode. The background of the web view on the Countries card is set to transparent to fix the issue.

NOTE: Please update the milestone to 20.8 if it's not frozen yet.

https://user-images.githubusercontent.com/2471769/190707221-f94bde3d-c6a8-4a2f-8fa4-01ac37c6d885.mp4

To test:

  1. Be in dark mode
  2. Go to Stats > Days/Weeks/Months/Years
  3. Scroll down to find the Countries card
  4. Ensure there is no white background on the countries card while loading.
  5. Tap "view more" on the Countries card
  6. Ensure there is no white loading state.

Regression Notes

  1. Potential unintended areas of impact Light mode of countries card.

  2. What I did to test those areas of impact (or what existing automated tests I relied on) Tested manually.

  3. What automated tests I added (or what prevented me from doing so) I didn't add an automated test because it's a small UI fix.

PR submission checklist:

  • [x] I have completed the Regression Notes.
  • [x] I have considered adding accessibility improvements for my changes.
  • [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

irfano avatar Sep 16 '22 18:09 irfano

You can test the WordPress changes on this Pull Request by downloading an installable build (wordpress-installable-build-pr17169-6ba9f5a.apk), or scanning this QR code:

wpmobilebot avatar Sep 16 '22 18:09 wpmobilebot

You can test the Jetpack changes on this Pull Request by downloading an installable build (jetpack-installable-build-pr17169-6ba9f5a.apk), or scanning this QR code:

wpmobilebot avatar Sep 16 '22 18:09 wpmobilebot