WordPress-Android icon indicating copy to clipboard operation
WordPress-Android copied to clipboard

Reader: "Manage Topics & Sites" not translated

Open thehenrybyrd opened this issue 3 years ago • 3 comments

Expected behavior

In Reader, the "Manage Topics & Sites" settings heading should be translated.

Actual behavior

Heading is not translated.

Steps to reproduce the behavior

  1. In Me > App Settings, change Interface Language to one of the Mag16 languages.
  2. Head into Reader and tap the "gear" icon.
  3. Note that "Manage Topics & Sites" is in English.
Tested on Samsung Galaxy S21, Android 12, WPAndroid 20.6-rc-3

thehenrybyrd avatar Sep 01 '22 09:09 thehenrybyrd

@thehenrybyrd I am picking this task

debojyoti452 avatar Sep 06 '22 03:09 debojyoti452

The translation doesn't work only when the language is translated via App settings, not device settings. "Manage Topics & Sites" is not the only translation with the issue. When we found the root cause, we should check for other strings too. At first glance, I found Follow topics screens are not translated too.

irfano avatar Sep 06 '22 08:09 irfano

The translation doesn't work only when the language is translated via App settings, not device settings. "Manage Topics & Sites" is not the only translation with the issue. When we found the root cause, we should check for other strings too. At first glance, I found Follow topics screens are not translated too.

@irfano It's happening because setting label from manifest will not work with locale change during runtime, so we need to add title from activity and will start working, soon will push the PR for this fix.

debojyoti452 avatar Sep 09 '22 07:09 debojyoti452