WordPress-Android icon indicating copy to clipboard operation
WordPress-Android copied to clipboard

Reader search screen doesn't give any feedback to the user when there's no internet connection.

Open gitstart opened this issue 3 years ago • 1 comments
trafficstars

Fixes #16997

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • [x] I have completed the Regression Notes.
  • [x] I have considered adding accessibility improvements for my changes.
  • [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Before:

https://user-images.githubusercontent.com/16153555/183618673-c19e9b1d-5e1f-489d-8ad6-7fdcabae0645.mp4

After: https://www.loom.com/share/26ddf88029764fa6935a4862894b31ba

Ticket Link: https://app.gitstart.com/clients/wordpressandroid/tickets/WPA-44

gitstart avatar Aug 24 '22 06:08 gitstart

Warnings
:warning: PR is not assigned to a milestone.

Generated by :no_entry_sign: dangerJS

Thank you @irfano for reviewing the PR, Added updated loom video and pushed requested changes. Please have a look. 🙌

gitstart avatar Oct 07 '22 09:10 gitstart