WordPress-Android icon indicating copy to clipboard operation
WordPress-Android copied to clipboard

Fix detekt suppressed errors in baseline.xml after bump to 1.19.0

Open RenanLukas opened this issue 3 years ago • 1 comments

In #16819 we had to bump detekt version to 1.19.0, and because of that we had to suppress over 100 existing errors in baseline.xml. They should be fixed and the PRs should be listed in this issue:

  • ...

RenanLukas avatar Jun 27 '22 14:06 RenanLukas

We're splitting #16819 into two separate work items, where the Detekt bump to 1.19.0 will be handled separately.

Key takeaways from the discussions in that PR:

  • We plan switching to buildUponDefaultConfig = true, more on the implications of doing so here and here.
  • There will probably be more checks that will need suppression as a result of switching to buildUponDefaultConfig = true. The scope of this issue is to keep the baseline.xml at least with the same number of suppressions as it was before updating to 1.19.0. But of course, if we can manage to fix more then it's even better, as one of our long-term tasks is to cleanup the baseline file and use inline suppressions or addressing the reported lines of code with fixes when applicable.

ovitrif avatar Jun 27 '22 15:06 ovitrif