No network check for saving tags

[carl-duncan]

trafficstars

Fixes #15590

Added the network check to onResume

To test:

Go into site settings Open the tags Go into airplane mode Go into the app and close the tags section

Regression Notes

1. Potential unintended areas of impact

2. What I did to test those areas of impact (or what existing automated tests I relied on)

3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

• [x] I have completed the Regression Notes.
• [x] I have considered adding accessibility improvements for my changes.
• [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[peril-wordpress-mobile[bot]]

	Warnings
:warning:	PR is not assigned to a milestone.

Generated by :no_entry_sign: dangerJS

[carl-duncan]

Thank you I will check it out!

[carl-duncan]

@AjeshRPai Hey , fixed the issue for that specific interaction.

[AjeshRPai]

@carl-duncan Thanks for making the change. I feel now the behaviour is not user-friendly. When the user clicks on a setting, I would say it's better to show a snack bar with no connection message rather than closing the site settings page itself. The user might be unable to figure out what went wrong there as there are items like Site Title, Tag line etc., which we can edit without the internet. WDYT?

[carl-duncan]

@carl-duncan Thanks for making the change. I feel now the behaviour is not user-friendly. When the user clicks on a setting, I would say it's better to show a snack bar with no connection message rather than closing the site settings page itself. The user might be unable to figure out what went wrong there as there are items like Site Title, Tag line etc., which we can edit without the internet. WDYT?

Thank you again for the review, Yeah I agree, It would be a better user experience and easier for them to take their next step to fix the connection and continue.

[carl-duncan]

Hey @AjeshRPai , I added a toast to display when a user is trying to save a toast when there is no connection. I think that would be the best course of action as users will still have easy access to create a tag once they get connectivity and not break the UI.

[AjeshRPai]

@carl-duncan I have tested the latest changes. I still see the freezing issue when I try to add a tag without internet. I am not able to see any toast with an internet connection error. Please find the below video capture showing the behaviour.

https://user-images.githubusercontent.com/17463767/174618822-b01c161f-40d4-4a4d-8dbd-7d69eadd6c43.mp4

I believe the better fix would be to show a no internet toast on clicking at the Tags/Timezone settings if we don't have internet. No need to finish the activity but show the No Internet connection toast. WDYT?. 🤔

[carl-duncan]

@carl-duncan I have tested the latest changes. I still see the freezing issue when I try to add a tag without internet. I am not able to see any toast with an internet connection error. Please find the below video capture showing the behaviour.

Screen_Recording_20220620-192050_WordPress.Pre-Alpha.mp4 I believe the better fix would be to show a no internet toast on clicking at the Tags/Timezone settings if we don't have internet. No need to finish the activity but show the No Internet connection toast. WDYT?. 🤔

Hey @AjeshRPai could you retest with mobile data off as well?

[AjeshRPai]

Hey @carl-duncan , Sorry for the late reply.

Hey @AjeshRPai could you retest with mobile data off as well

Same behaviour as above in the Video capture. The screen freezes.