WordPress-Android icon indicating copy to clipboard operation
WordPress-Android copied to clipboard

Published 20 hours ago • verified publisher icon wordpress-mobile

Use shared Gradle dependency cache from dependency catalog

Open oguzkocer opened this issue 3 years ago • 5 comments

This PR adds a pre-command Buildkite hook which restores the our global Gradle dependency cache we create from https://github.com/Automattic/android-dependency-catalog/ project. It uses the restore_gradle_dependency_cache script introduced in https://github.com/Automattic/bash-cache-buildkite-plugin/pull/25 which includes more information about how our caching works. Errors during cache restoration will not halt the builds since it's optional.

To test:

Regression Notes

  1. Potential unintended areas of impact N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on) N/A

  3. What automated tests I added (or what prevented me from doing so) N/A

PR submission checklist:

  • [x] I have completed the Regression Notes.
  • [x] I have considered adding accessibility improvements for my changes.
  • [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

oguzkocer avatar May 18 '22 18:05 oguzkocer

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

peril-wordpress-mobile[bot] avatar May 18 '22 18:05 peril-wordpress-mobile[bot]

You can test the changes on this Pull Request by downloading the APKs:

peril-wordpress-mobile[bot] avatar May 18 '22 19:05 peril-wordpress-mobile[bot]

@oguzkocer I once again just bumped the milestone for this as I'm doing the code freeze for 20.5… but I'm wondering if this Draft PR is still in the works (as it was opened in May) and was just postponed due to other priorities, or if it had just been… forgotten 😅

AliSoftware avatar Aug 08 '22 09:08 AliSoftware

@AliSoftware I am so sorry, I didn't realize this PR had a milestone on it. I just removed it.

We want to keep this as a draft PR until we can utilize the dependency cache. It's something I just prepared in advance while working on other repos. Sorry about the hassle :(

oguzkocer avatar Aug 08 '22 19:08 oguzkocer

@oguzkocer no need to be sorry at all, there was no hassle 🙂 I just wanted to make sure this was not a forgotten draft PR 🙂

As long as it isn't forgotten and that this PR still being open and around as draft is intentional, all is good 😊

AliSoftware avatar Aug 09 '22 07:08 AliSoftware

I am going to close this PR for now and dig it up whenever we are ready to start using the dependency cache.

oguzkocer avatar Dec 09 '22 19:12 oguzkocer