WordPress-Android icon indicating copy to clipboard operation
WordPress-Android copied to clipboard

Whitelisted IP addresses pref doesn't work in Jetpack settings

Open malinajirka opened this issue 4 years ago • 4 comments

Expected behavior

When I click on "Whitelisted IP addresses" in Jetpack Security settings I expect "Whitelisted IP Addresses" screen to show up.

Actual behavior

When I click on "Whitelisted IP addresses" in Jetpack Security settings nothing happens.

~Note 1: The theme issue is fixed in this PR.~ ~Note 2: This issue is blocking https://github.com/wordpress-mobile/WordPress-Android/pull/13402 and https://github.com/wordpress-mobile/WordPress-Android/pull/13408~ Note 3: It seems the logic was actually never even implemented. It works fine when the Jetpack Security settings are accessed from My Site -> Settings -> Security -> Whitelisted IP Addresses.

Steps to reproduce the behavior

Prerequisites - jetpack site

  1. Create a post on the web with a blog which is not supported on mobile
  2. Open My Site -> Settings -> (Jetpack) Security -> disable "Allow WordPress.com login"
  3. Go to My Site -> Blog Posts -> open the post from step 1
  4. Click on the question mark on the unsupported block
  5. Click on "Open Jetpack Security Settings"
  6. Click on "Whitelisted IP Addresses"
  7. Notice nothing happens

Update 11/24 When https://github.com/wordpress-mobile/WordPress-Android/pull/13402 is merged this issue won't be reproducible anymore. The row was removed in this PR. Goal of this task is to re-add that option. (it's still available when the settings are accessed from My Site-> Site Settings -> Security)

Prerequisites - jetpack site

  1. My Site
  2. Click on "Jetpack settings" option
  3. Notice the "whitelisted IP addresses" option is not shown

malinajirka avatar Nov 17 '20 09:11 malinajirka