AztecEditor-Android icon indicating copy to clipboard operation
AztecEditor-Android copied to clipboard

Inline format is not preserved on new line

Open kulkarni46 opened this issue 3 years ago • 3 comments

Expected

Inline format should be preserved on new line like in other standard editors

Observed

Inline format gets removed on new line

Reproduced

  1. Select Bold and type something
  2. Enter a new line
  3. Type new text. Bold format gets removed

Tested

[One Plus 7 Pro] on [11] with [1.5.3]

Seems like existing behaviour for library. I have made a fix by making local changes to the library under applyInlineStyle in InlineFormatter.kt by moving the start position to first character before '\n' and checking its span. Also dropped newline check under handleInlineStyling() in InlineFormatter.kt

Please let me know if this logic needs to be submitted as a Pull Request to the Editor

kulkarni46 avatar Feb 01 '22 08:02 kulkarni46

Please let me know if this logic needs to be submitted as a Pull Request to the Editor

Thanks for ticket @kulkarni46 and sure, feel free to open a PR! That said, not many folks are focused on Aztec at the moment so, it might take a bit of time for the review to go through.

hypest avatar Feb 02 '22 10:02 hypest