wp-api-angular icon indicating copy to clipboard operation
wp-api-angular copied to clipboard

Auth API

Open karrirasinmaki opened this issue 6 years ago • 3 comments

I've been working with WP authentication and implementing it into this library.

I've been testing this in my own projects for a while now. Still, some work needs to be done before actually merging this into distribution.

Needs to be done:

  • Update documentation
  • Better token / session saving
  • Cleaning the code to fit the original project structure

karrirasinmaki avatar Feb 09 '18 07:02 karrirasinmaki

really nice work! Though for some reason your push 33 commits and I cannot merge it.

Can you try rebasing? also do not bump versions, I will do it.

thanks

shprink avatar Feb 09 '18 19:02 shprink

Thanks! I think I created my branch originally from master. Changed the PR base branch according.

karrirasinmaki avatar Feb 09 '18 21:02 karrirasinmaki

Oh, and couple things to note/ask:

  • In API class files (eq. src/Users.ts) there were interface code written. However, the same interface was defined in interfaces.ts, so I decided to import those interfaces from there and wrote those in a single place only. Was there some purpose of writing the same code in multiple places?
  • Updated angular libraries in package.json from ^4.0.0 to ^4.4.6. Might not be necessary.

karrirasinmaki avatar Feb 09 '18 21:02 karrirasinmaki