markdown-rs icon indicating copy to clipboard operation
markdown-rs copied to clipboard

Published 20 hours ago • verified publisher icon wooorm

Fix serde

Open sshwy opened this issue 1 year ago • 3 comments

This pr is trying to fix #72.

sshwy avatar Jul 11 '23 03:07 sshwy

Can you add a a test that breaks before your change, and works now? Thanks.

wooorm avatar Jul 11 '23 05:07 wooorm

Can you add a a test that breaks before your change, and works now? Thanks.

I've added a simple test for it. I know it is not sufficient to prove that the result of serialization is consisitent with mdast's type definition. However I'm getting a little busy these days, so it may take a long time for me to write a more thorough test if you urge :).

sshwy avatar Jul 11 '23 12:07 sshwy

Tests fail, I think this is because you’re now testing serde, but it’s an optional dependency, and should be a required dev-dependency?

wooorm avatar Jul 12 '23 11:07 wooorm