Titus
Titus
How could that be an issue? Can you please provide exactly how you are using `react-markdown`.
Thanks for more info. So you don’t have dynamic children, which is what this issue is about. Your problem seems to be Parcel being broken: https://github.com/remarkjs/react-markdown/issues/747#issuecomment-1674930974. Hiding these comments so...
Thanks but no thanks!
> preserve Why not just go with `test(node: Comment)` / `test(value: string)`? > Even the IE directive pass through could and potentially should be removed in the next major. :+1:...
> I think test is used more often within the unified ecosystem, so that makes sense. Indeed. > Passing a RegExp would be nice, but this could also be implemented...
> Personally I lean against accepting a string until this is something a user actually asks for. They can use JavaScript config files, but I think typically this is used...
> The exact same thing can be said about JavaScript minifiers preserving such comments. My point is that it’s completely different: js/css minifiers have this option because OSS licenses (MIT...
OK, I think a PR for `test(value: string)` is acceptable!
Released in https://github.com/rehypejs/rehype-minify/releases/tag/rehype-remove-comments%406.1.0!
While the core of `markdown-rs` is `no-std + alloc`, that’s for the use case where you only really do markdown -> html, straight. Here we are working with ASTs. I...