Octo.jl icon indicating copy to clipboard operation
Octo.jl copied to clipboard

Support for delete! with multiple ids

Open BrandonEscamilla opened this issue 2 years ago • 3 comments

Hi!

It would be great if we "delete!" could handle deleting multiple IDs, similar to how insert! works. Is it possible to implement this functionality? Thank you in advance!

BrandonEscamilla avatar Sep 06 '23 11:09 BrandonEscamilla

could you test it with master branch?

julia> using Pkg
julia> Pkg.develop("Octo")

you could test like this https://github.com/wookay/Octo.jl/commit/51d5046e6ce7ea57d28b6407b76f5fd3d4ba5ec4#diff-8be19b1fddcbea3316c76de3fb4388391b75f17e597d1905d50599c9ee905568

wookay avatar Sep 07 '23 03:09 wookay

Just testing, I guess this doesn't work if the Pk is not a Int but a uuid?

BrandonEscamilla avatar Sep 07 '23 10:09 BrandonEscamilla

@BrandonEscamilla oh. it seems to be work with uuid String. you could test like this https://github.com/wookay/Octo.jl/commit/29321f96440ec493e733d29bcd53790e6ee91473#diff-78ee68626d990c0368561a382f7c86ba2614a9e5150858a9c073da98abf3b5b3

wookay avatar Sep 07 '23 12:09 wookay