Jive.jl icon indicating copy to clipboard operation
Jive.jl copied to clipboard

release compatible with Julia 1.10?

Open dpinol opened this issue 1 year ago • 3 comments

Hi, any plans to release a new version to enable compatibility with Julia 1.10?

thanks

dpinol avatar Feb 26 '24 12:02 dpinol

is there any problem with it? CI just works fine yet. https://github.com/wookay/Jive.jl/actions/runs/7434456541

wookay avatar Feb 27 '24 02:02 wookay

maybe it works because it runs with master?

If I run

using Test

@testset "state" begin
    @test 40 < 30
 end

which fails with runtest, I get this error with 0.2.27. With master, it works fine

state: Test Failed at /home/dani/source/repos/sc-engine/ci/kk/kk.jl:4
  Expression: 40 < 30
   Evaluated: 40 < 30
state: Error During Test at /home/dani/source/repos/sc-engine/ci/kk/kk.jl:3
  Got exception outside of a @test
  MethodError: no method matching scrub_backtrace(::Vector{Union{Ptr{Nothing}, Base.InterpreterIP}})
 
  Closest candidates are:
    scrub_backtrace(::Any, ::Any, ::Any)
     @ Test /opt/julia/julia-1.10.1/share/julia/stdlib/v1.10/Test/src/Test.jl:89
  
  Stacktrace:
    [1] record(ts::Jive.JiveTestSet, t::Test.Fail)
      @ Jive ~/.julia/packages/Jive/8tjab/src/runtests_testset.jl:55
    [2] do_test(result::Test.ExecutionResult, orig_expr::Any)
      @ Test /opt/julia/julia-1.10.1/share/julia/stdlib/v1.10/Test/src/Test.jl:705
    [3] macro expansion
      @ /opt/julia/julia-1.10.1/share/julia/stdlib/v1.10/Test/src/Test.jl:672 [inlined]
    [4] macro expansion
      @ ~/source/repos/sc-engine/ci/kk/kk.jl:4 [inlined]
    [5] macro expansion
      @ /opt/julia/julia-1.10.1/share/julia/stdlib/v1.10/Test/src/Test.jl:1577 [inlined]
    [6] top-level scope
      @ ~/source/repos/sc-engine/ci/kk/kk.jl:4
    [7] include
      @ ./Base.jl:495 [inlined]
    [8] include_test_file(context::Nothing, filepath::String)
      @ Jive ~/.julia/packages/Jive/8tjab/src/runtests.jl:185
    [9] jive_lets_dance
      @ ~/.julia/packages/Jive/8tjab/src/runtests.jl:245 [inlined]
   [10] normal_run(dir::String, tests::Vector{String}, start_idx::Int64, context::Nothing, verbose::Bool)
      @ Jive ~/.julia/packages/Jive/8tjab/src/runtests.jl:209
   [11] runtests(dir::String; skip::Vector{String}, node1::Vector{Any}, targets::Vector{String}, testset::Nothing, enable_distributed::Bool, stop_on_failure::Bool, context::Nothing, verbose::Bool)
      @ Jive ~/.julia/packages/Jive/8tjab/src/runtests.jl:164
   [12] runtests(dir::String)
      @ Jive ~/.julia/packages/Jive/8tjab/src/runtests.jl:135

dpinol avatar Feb 27 '24 08:02 dpinol

thanks for the release! :bow:

dpinol avatar Feb 27 '24 10:02 dpinol

fixed

dpinol avatar Dec 17 '24 10:12 dpinol