H3.jl icon indicating copy to clipboard operation
H3.jl copied to clipboard

Feature Request: GeoInterface Integration

Open joshday opened this issue 2 months ago • 5 comments

joshday avatar Oct 03 '25 14:10 joshday

https://github.com/JuliaGeo/GeoInterface.jl

wookay avatar Oct 03 '25 22:10 wookay

Would be nice to have more info on what you want to integrate (and for what usecase). Is it just polygons from h3 as some form of struct, or do you want the tree representation to be GeometryOps-compatible? Both can be done but it's also a question of how those can be structured.

asinghvi17 avatar Oct 15 '25 14:10 asinghvi17

I actually have a lot of my use case done! I'll create a PR soon.

joshday avatar Oct 15 '25 19:10 joshday

@wookay The PR I had in mind was turning pretty big, so I put my work here: https://github.com/joshday/HexEarth.jl

The gist of the GeoInterface integration is presented here: https://joshday.github.io/HexEarth.jl/dev/geometry_to_cell/

Take a look and let me know if you'd prefer this stuff to live in H3.jl or a different package. I'd like to avoid fragmenting packages, but I also don't want to burden you with involuntary maintenance.

joshday avatar Oct 20 '25 18:10 joshday

This is what I felt after looking around your HexEarth.jl package.

  1. H3.API._check_h3error By convention, functions starting with _ are internal. I think that it needs to define the function with a better name.

  2. using H3.Lib functions with Ref pointer types Add it to H3.API which provides the same functionality.

I hope this helps you develop your package without any inconvenience.

wookay avatar Oct 21 '25 12:10 wookay