zen icon indicating copy to clipboard operation
zen copied to clipboard

Obey EC rules

Open szepeviktor opened this issue 10 months ago • 3 comments

Can be checked on your local machine/CI workflow with https://github.com/greut/eclint

szepeviktor avatar Aug 20 '23 01:08 szepeviktor

Oh no!! DefinitionCompilation does not agree with me.

szepeviktor avatar Aug 20 '23 01:08 szepeviktor

Codecov Report

Merging #20 (3a3a0b3) into master (568daf2) will decrease coverage by 0.08%. Report is 1 commits behind head on master. The diff coverage is 100.00%.

:exclamation: Current head 3a3a0b3 differs from pull request most recent head 47c1a2c. Consider uploading reports for the commit 47c1a2c to get more accurate results

@@             Coverage Diff              @@
##             master      #20      +/-   ##
============================================
- Coverage     89.60%   89.52%   -0.08%     
- Complexity      437      438       +1     
============================================
  Files            33       33              
  Lines          1193     1203      +10     
============================================
+ Hits           1069     1077       +8     
- Misses          124      126       +2     
Files Coverage Δ
src/Container/Definition/AbstractDefinition.php 77.90% <100.00%> (+1.95%) :arrow_up:
src/Container/Definition/ClassDefinition.php 96.25% <100.00%> (+0.07%) :arrow_up:

... and 2 files with indirect coverage changes

codecov[bot] avatar Aug 20 '23 02:08 codecov[bot]

It was berry 🍓 hard to forge strings!

szepeviktor avatar Aug 20 '23 02:08 szepeviktor