woodser

Build universal shared libraries for macOS [2 XMR]

3

Currently, the .dylib shared libraries built on macOS are platform-dependent, so they need generated for both x86_64 and ARM64. This issue requests building the libmonero-cpp.dylib and libmonero-java.dylib as universal shared...

Segfault creating multisig txs on Windows

1

On Windows, the native libraries crash with a segfault creating a multisig tx.

Support building static libraries with shared library wrapper [4 XMR]

3

This issue requests building monero-java and [monero-cpp](https://github.com/woodser/monero-cpp) to static libraries so all dependencies are self-contained, with a shared library wrapper to access libmonero-java in JNI. For example: libmonero-cpp.a, libmonero-java.a, and...

Incorrect test address from admin server

1

Running `./src/monero-lws-admin --network test create_admin` gives this result: ``` {"address":"9sAejnQ9EBR111111111111111111111111111111111158LRbrc6UMRoz1ZnUWGiscDUfXDZHcmf1CiQW6F2NxTMT6zULn","key":"e59fdce5b27b8b0c664feb895debef40f8d78f6a2f59a3afa761d14a644d2500"} ``` The address can't be right, can it?

Build error on release-v0.3_0.18 branch due to C++ 17

1

I'm getting this error building on the release-v0.3_0.18 branch: ``` In file included from /Users/woodser/git/monero-lws/src/db/string.cpp:30: /Users/woodser/git/monero-java/external/monero-cpp/external/monero-project/src/cryptonote_basic/cryptonote_basic_impl.h:43:29: error: no template named 'unary_function' in namespace 'std'; did you mean '__unary_function'? struct array_hasher:...

Remove refresh from call from import_multisig

2

This issue requests removing the `refresh` call from wallet2's `import_multisig` if possible: https://github.com/monero-project/monero/blob/c8214782fb2a769c57382a999eaf099691c836e7/src/wallet/wallet2.cpp#L13892 Refreshing is a relatively expensive operation which can take considerable time, especially over tor, and the wallet...

Currently monero-wallet-rpc supports [getting transfers](https://www.getmonero.org/resources/developer-guides/wallet-rpc.html#get_transfers) with the `pool` option to return unconfirmed transfers in the pool. However, this option will always [update the pool state from the daemon](https://github.com/monero-project/monero/blob/c8214782fb2a769c57382a999eaf099691c836e7/src/wallet/wallet_rpc_server.cpp#L2681) to get...

Support updating the pool state in monero-wallet-rpc `refresh`

1

Currently, monero-wallet-rpc's [`refresh`](https://www.getmonero.org/resources/developer-guides/wallet-rpc.html#refresh) call does not support fetching the latest pool state from the daemon. This issue requests adding a parameter to monero-wallet-rpc's `refresh` call to fetch the latest pool...

Support multiple destinations in make_uri and parse_uri

20

monero-wallet-rpc supports [make_uri](https://www.getmonero.org/resources/developer-guides/wallet-rpc.html#make_uri) and [parse_uri](https://www.getmonero.org/resources/developer-guides/wallet-rpc.html#parse_uri) which can be used to create a request for payment which the sender can parse to pay. These calls currently only support a single destination...

Should this return false to indicate non-mature currencies do not have chargeback risk? They can have chargeback risk too, no? https://github.com/bisq-network/bisq/blob/4fc0ab5d19c4da81ac857b3dbe4dffc2a3431bd5/core/src/main/java/bisq/core/payment/payload/PaymentMethod.java#L462