ruby-mpv icon indicating copy to clipboard operation
ruby-mpv copied to clipboard

[WIP] trying to reach feature parity with mpv scripts

Open pigoz opened this issue 5 years ago • 5 comments

Hello. I've been working on https://github.com/pigoz/lat using this gem as a base to write a Ruby mpv script. I'm in the process of upstreaming the features I've added (key bindings, observers), automated tests, and simplifications to the event loop. I'm still figuring out an API to deal with generic events and one to wait for a certain event. The idea is to allow people to write mpv scripts in ruby instead of Lua / JavaScript.

The exciting part is mpv recently added a way to run any kind of executable script, so you can do stuff like mpv --script=/path/to/ruby-script (See: https://github.com/mpv-player/mpv/commit/e2ab6b7f3567542a2a1b5aab053d513737e72878)

It's not ready to merge yet. But I wanted to start collecting some feedback. If the breaking changes are too many, please say so :)

pigoz avatar Feb 23 '20 21:02 pigoz

Thanks for hacking at this! Let me know when it's ready for review.

woodruffw avatar Feb 27 '20 02:02 woodruffw

I should have backported everything from my original gem (while making it much nicer/robust). Next Sunday I will port my "user gem" to use this version of the library in order to dogfood it a little bit.

Still unsure about the Ass:: APIs. I'll think about something better because it's a bit 💩 right now.

pigoz avatar Mar 01 '20 21:03 pigoz

I just realized that this has been sitting idle for a bit. Is there anything else it needs before I do some review @pigoz?

woodruffw avatar Sep 24 '20 03:09 woodruffw

Yes, sorry. My fault. I was not happy at all with the API for drawing to the OSD but my short attention span prevented me from coming up with something. I might actually remove from this PR so it can move forward.

pigoz avatar Sep 24 '20 06:09 pigoz

No problem at all! Just wanted to see if there was anything I could help with 🙂

Sent from mobile. Please excuse my brevity.

On Sep 24, 2020, at 2:05 AM, Stefano Pigozzi [email protected] wrote:

 Yes, sorry. My fault. I was not happy at all with the API for drawing to the OSD but my short attention span prevented me from coming up with something. I might actually remove from this PR so it can move forward.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

woodruffw avatar Sep 24 '20 12:09 woodruffw