chore(deps): update dependency eslint to v9 - abandoned

[renovate[bot]]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
eslint (source)	^8.56.0 -> ^9.0.0

---

Release Notes

eslint/eslint (eslint)

v9.0.0

Compare Source

---

Configuration

📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - "before 4am" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by Mend Renovate. View repository job log here.

[qwerty287]

This update is not possible yet because most plugins don't support eslint 9 yet. I started migration work for the other ones

Waiting for:

• https://github.com/import-js/eslint-plugin-import/issues/2948
• https://github.com/airbnb/javascript/issues/2961
• https://github.com/iamturns/eslint-config-airbnb-typescript/issues/331
• https://github.com/eslint-community/eslint-plugin-promise/issues/449

[renovate[bot]]

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

[renovate[bot]]

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

[anbraten]

@qwerty287 I did some further testing to update to v9. https://github.com/antfu/eslint-config seems to be a quite common preset including a nice set of rules. I've also added @intlify/eslint-plugin-vue-i18n to detect missing translations. What do you think?

[qwerty287]

In general looks fine, but I didn't look into details. If we still have most of the linters we had before I'm totally fine it.

[qwerty287]

@anbraten Can you take a look at my recent commits?

I'm fine with using antfu so far.

What I changed:

• enabled some additional plugins and configs we used before (if they're not included in antfu)
• cleaned up dependencies
• fixed most issues - those are not solved yet: I don't know/am unsure about how to fix. Can you check them?

Two questions:

1. Why did you remove the prettier plugin?
2. Does antfu check import sorting?

Only the promise plugin is missing eslint 9 support now, so I think we could merge this and enable the plugin later.

[anbraten]

• Why did you remove the prettier plugin?

Eslint by default does not have any stylistic rules anymore. Therefore it normally does not interfere with prettier.

• Does antfu check import sorting?

I wanted to start using @ianvs/prettier-plugin-sort-imports instead as its much faster with autosorting in ides.

[qwerty287]

I wanted to start using @ianvs/prettier-plugin-sort-imports instead as its much faster with autosorting in ides

Do you want to add it here or in a new PR?

[qwerty287]

@anbraten I added it in https://github.com/woodpecker-ci/woodpecker/pull/3594/commits/68f70003fecfef47aa2bba5e3e99a917357b71fb - but now there's one problem: Because we use the same prettier config file, it does not work anymore if you run prettier from the root dir because the plugin is missing. See https://ci.woodpecker-ci.org/repos/3780/pipeline/16716/24

[qwerty287]

@anbraten fixed the prettier problem by using a separate config in the web dir importing the root one.

Could you check the remaining issues eslint finds? Then it's good to go.

Also, tsc finds some issues I don't know how to fix: https://ci.woodpecker-ci.org/repos/3780/pipeline/16894/29

[woodpecker-bot]

Tearing down https://woodpecker-ci-woodpecker-pr-3594.surge.sh