woodpecker icon indicating copy to clipboard operation
woodpecker copied to clipboard

Step logs removing API and Button

Open zc-devs opened this issue 1 year ago • 9 comments

Closes #3444 closes #1272


Admin: Screenshot 2024-02-27 1 Screenshot 2024-02-27 2 Screenshot 2024-02-27 3

User: Screenshot 2024-02-27 4

zc-devs avatar Feb 27 '24 16:02 zc-devs

go-sdk missing

6543 avatar Feb 28 '24 00:02 6543

Deployment of preview was torn down

woodpecker-bot avatar Feb 28 '24 00:02 woodpecker-bot

also as per CI :D -> go generate cmd/server/swagger.go and commit

6543 avatar Feb 28 '24 00:02 6543

also as per CI :D -> go generate cmd/server/swagger.go and commit

Unfortunately, nothing changed :( go-generate-swagger.log

zc-devs avatar Feb 28 '24 08:02 zc-devs

usr before deleting (admin also have access to this button):

Screenshot 2024-03-01 211151

usr2 after deleteion, the same for guest:

Screenshot 2024-03-01 211525

zc-devs avatar Mar 01 '24 18:03 zc-devs

Can you allow this also for repo push access? The endpoint to delete the whole pipeline's logs is also available with push access only.

qwerty287 avatar Mar 03 '24 10:03 qwerty287

Ideally would be if the delete button would be hidden under the sub menu under the button with horizontal ... icon or something like that (not requirement for this PR)

lafriks avatar Mar 20 '24 15:03 lafriks

@6543 you requested changes, but your concerns were addressed @zc-devs Can you fix the linters?

qwerty287 avatar Mar 28 '24 08:03 qwerty287

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 35.92%. Comparing base (8e45ddd) to head (b9fc970). Report is 4 commits behind head on main.

:exclamation: Current head b9fc970 differs from pull request most recent head de8e1d6. Consider uploading reports for the commit de8e1d6 to get more accurate results

Files Patch % Lines
server/api/pipeline.go 0.00% 39 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3451      +/-   ##
==========================================
- Coverage   35.98%   35.92%   -0.07%     
==========================================
  Files         231      231              
  Lines       15553    15602      +49     
==========================================
+ Hits         5597     5605       +8     
- Misses       9539     9580      +41     
  Partials      417      417              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 28 '24 09:03 codecov[bot]

@6543 can you take a look here? You requested changes so we cant merge without your approval

qwerty287 avatar Apr 09 '24 14:04 qwerty287

PS: sorry for the delay

6543 avatar Apr 14 '24 23:04 6543