woodpecker icon indicating copy to clipboard operation
woodpecker copied to clipboard

Header and Tabs UI Improvements

Open dvjn opened this issue 2 years ago • 2 comments

Some improvements to the Page Header and Tab UI.

Original New
image image
image image

What?

  • Create a new Scaffold component, which includes the header and tabs required for a page.
  • Use this component to wrap all the views that have a header.

Why?

  • Ensures consistency in headers between different pages.
  • (Opinion) Looks better than the current headers.

TODO:

  • [ ] Add support to use custom html/component in place of title (for repo page, pipeline page, etc)
  • [ ] Add support of right icon buttons (for repo page, pipeline page, etc)
  • [ ] Refactor tabs handling using compositions (useTabsProvider, useTabsClient)

dvjn avatar Oct 19 '22 06:10 dvjn

@6543 @qwerty287 @anbraten (or any other maintainer) could you review the visual changes / code changes, while I implement the rest of the changes?

My first time using vue :)

dvjn avatar Oct 19 '22 06:10 dvjn

For me, this looks good.

qwerty287 avatar Oct 19 '22 06:10 qwerty287

Can anyone please review this?

Thanks!

dvjn avatar Oct 22 '22 20:10 dvjn

Any updates?

dvjn avatar Oct 24 '22 15:10 dvjn

New search looks a bit too unreadable (background/foreground contrast)

lafriks avatar Oct 24 '22 16:10 lafriks

New search looks a bit too unreadable (background/foreground contrast)

Are you talking about the placeholder text? If yes, I'll just set it to a darker color.

dvjn avatar Oct 24 '22 16:10 dvjn

@lafriks done :)

Before: image

After: image

dvjn avatar Oct 24 '22 17:10 dvjn

I'll trust you so I'll merge

6543 avatar Oct 27 '22 22:10 6543

;)

6543 avatar Oct 27 '22 22:10 6543