woodpecker
woodpecker copied to clipboard
WIP: move constrain to only have a single command in backend to run to dedicated backends
at the moment we compile a script that we can pipe in as single command this is because of the constrains the docker backend gives us.
so we move it into the docker backend and eventually get rid of it altogether
Sounds nice. My idea for the docker backend was to run each command step with docker exec
instead of using the script and executing it via docker run
once. This would allow us to change the entrypoint as well: #278
Codecov Report
Base: 45.08% // Head: 44.93% // Decreases project coverage by -0.14%
:warning:
Coverage data is based on head (
c7b4413
) compared to base (280d27d
). Patch coverage: 2.12% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## master #1032 +/- ##
==========================================
- Coverage 45.08% 44.93% -0.15%
==========================================
Files 138 138
Lines 9988 9959 -29
==========================================
- Hits 4503 4475 -28
- Misses 5209 5211 +2
+ Partials 276 273 -3
Impacted Files | Coverage Δ | |
---|---|---|
pipeline/backend/common/script.go | 0.00% <0.00%> (ø) |
|
pipeline/backend/common/script_posix.go | 100.00% <ø> (ø) |
|
pipeline/backend/common/script_win.go | 0.00% <ø> (ø) |
|
pipeline/backend/docker/convert.go | 8.59% <0.00%> (-0.14%) |
:arrow_down: |
pipeline/backend/docker/docker.go | 0.00% <ø> (ø) |
|
pipeline/backend/kubernetes/pod.go | 0.00% <0.00%> (ø) |
|
pipeline/frontend/yaml/compiler/convert.go | 0.00% <0.00%> (ø) |
|
pipeline/frontend/yaml/linter/linter.go | 74.71% <ø> (+0.42%) |
:arrow_up: |
pipeline/frontend/yaml/container.go | 82.35% <100.00%> (ø) |
|
server/queue/fifo.go | 83.13% <0.00%> (-3.62%) |
:arrow_down: |
... and 3 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Sounds nice. My idea for the docker backend was to run each command step with
docker exec
instead of using the script and executing it viadocker run
once. This would allow us to change the entrypoint as well: #278
that can be next ... (and yes i had this also in mind ... and less overhead)
Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-1032.surge.sh
After the changes put in via 30f113f it's working on Kubernetes with the Kubernetes backend active
https://test-ci.kle.li/sandbox/sq-test/pipeline/10/3
thanks again for the patience while I was stumbling through the setup
ok now it's just a refactor and do not change any behavior at all