plugin-git icon indicating copy to clipboard operation
plugin-git copied to clipboard

[Feature] - Windows/Amd64 image

Open cduchenoy opened this issue 1 year ago • 5 comments

Hi,

I would like to submit the following Dockerfile

in order to have a version of the plugin on Windows.

The Windows version has been in production for a month with several of our customers

But I don't know how to proceed because I understand that you don't have the Windows infrastructure to build the image

We have made the image available for Windows Server 2022 at dockerhub

cduchenoy avatar Nov 29 '24 09:11 cduchenoy

I guess #15 is required first as otherwise we can't use buildx to build for windows/amd64? But didn't look into it in detail.

pat-s avatar Dec 15 '24 22:12 pat-s

Hi,

Sorry for the late reply :(

You right to have a native plugin #15 must be resolved

But in the meantime, this Dockerfile now allows you to have a functional plugin on Windows.

If you do not want to build the image (or include this Dockerfile in source) could you reference the github https://github.com/GECO-IT/woodpecker-windows for people who would like to use Woodpecker on Windows OS?

/Cyril

cduchenoy avatar Jan 17 '25 09:01 cduchenoy

@cduchenoy sorry for not really coming back to you, but I think the problem is that nobody of us maintainers really uses windows and thus we can't really test this. Otherwise it would be great to have an image for windows of course. Maybe you can open a pull request with the dockerfile so we can check it out there?

qwerty287 avatar Jan 23 '25 13:01 qwerty287

We also use Linux exclusively but in each company we follow, we realize that there are tasks which can be simplified by CI automation but which require Windows.

So I think there is really a need to cover

Windows is a pain because it still isn't buildx compatible !

This Dockerfile was tested by @6543 cf https://github.com/woodpecker-ci/woodpecker/pull/4381

For our part I think we could make an Windows 2022 VM available to you

We could also reference our git in the awesome Woodpecker doc ?

What do you think ?

I will open an PR

cduchenoy avatar Jan 23 '25 14:01 cduchenoy

@cduchenoy sorry for not really coming back to you, but I think the problem is that nobody of us maintainers really uses windows and thus we can't really test this. Otherwise it would be great to have an image for windows of course. Maybe you can open a pull request with the dockerfile so we can check it out there?

I can already tell that we use this image with success in a number of our CI pipelines. It would be really nice if we can integrate this properly. I can help testing and fixing issues if they occur.

johanvdw avatar Jun 13 '25 07:06 johanvdw