woocommerce icon indicating copy to clipboard operation
woocommerce copied to clipboard

Freemium: update marketplace product card label

Open raicem opened this issue 2 years ago • 4 comments

Submission Review Guidelines:

Changes proposed in this Pull Request:

Change the label for Freemium products in the In-App Marketplace.

How to test the changes in this Pull Request:

  1. Checkout this branch
  2. Connect your WooCommerce dev environment to local Woo.com by changing the MARKETPLACE_HOST to https://woocommerce.test in the constants file
  3. Get a new build
  4. Visit the In-App Marketplace search and confirm free and paid products have the same label
    • :warning: The endpoint is cached two times. I set these variables (1, 2) to false to make sure I don't look at a cache.
    • Adding a search term that's not cached will also get you uncached results
  5. Locally, set one product as a primary Freemium
  6. Find a Freemium product by searching and confirm the label is "Free Plan Available"
  7. Please test around this issue

Changelog entry

  • [x] Automatically create a changelog entry from the details below.

Significance

  • [ ] Patch
  • [x] Minor
  • [ ] Major

Type

  • [ ] Fix - Fixes an existing bug
  • [x] Add - Adds functionality
  • [ ] Update - Update existing functionality
  • [ ] Dev - Development related task
  • [ ] Tweak - A minor adjustment to the codebase
  • [ ] Performance - Address performance issues
  • [ ] Enhancement - Improvement to existing functionality

Message Show the label for freemium products in the in-app marketpalce

Comment

raicem avatar Mar 27 '24 10:03 raicem

Test Results Summary

Commit SHA: 6b7a32d6a3dd38257db76c523acbf58c6ec8cbdd

Test :test_tube:Passed :white_check_mark:Failed :rotating_light:Broken :construction:Skipped :next_track_button:Unknown :grey_question:Total :bar_chart:Duration :stopwatch:
API Tests25900202610m 38s
E2E Tests37010903808m 48s

:warning: Warning

Please address the following issues prior to merging this pull request:
  • FAILED/BROKEN TESTS. There were failed and/or broken API and E2E tests.

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

github-actions[bot] avatar Mar 27 '24 10:03 github-actions[bot]

Hi @singerb, @kdevnel,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like: https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

github-actions[bot] avatar Apr 01 '24 15:04 github-actions[bot]

Just note, there are no links to the changes you mention in step 4 for the cache values. I didn't need them, but thought to mention it.

Thank you @kdevnel, I have fixed in case it's needed in the future.

I have rebased this on top of trunk and hopefully that'll resolve the e2e tests :crossed_fingers:

raicem avatar Apr 03 '24 18:04 raicem

Looks good! Now it seems the auto-changelog adder is failing to run. You could always add the changelog manually.

Yeah, I'm struggling with that now. I don't want to add a changelog item, I think this change is not worth it. I wanted to do a patch buy I haven't picked the Type. Maybe that's why. Re-running it now.

raicem avatar Apr 04 '24 14:04 raicem

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

github-actions[bot] avatar May 10 '24 18:05 github-actions[bot]