Add new 2019 Algerian states

[senadir]

trafficstars

In 2019, Algerian introduced 10 new states that were previously part of other bigger states, this PR adds them

https://en.wikipedia.org/wiki/Provinces_of_Algeria#Since_2019

It also fixes some misspellings:

Closes https://github.com/woocommerce/woocommerce/issues/33969

Testing steps:

• Make sure your shipping and billing countries include Algeria (default settings include all countries).
• In Checkout, select Algeria as a country.
• Scroll down, you should be able to see the new wilayats

[github-actions[bot]]

Test Results Summary

Commit SHA: d56cc7487933af98efb088ca98416871fa6294fd

Test :test_tube:	Passed :white_check_mark:	Failed :rotating_light:	Broken :construction:	Skipped :next_track_button:	Unknown :grey_question:	Total :bar_chart:	Duration :stopwatch:
API Tests	237	2	0	22	0	261	0m 41s
E2E Tests	335	0	0	16	0	351	7m 6s

:warning: Warning

Please address the following issues prior to merging this pull request:

• FAILED/BROKEN TESTS. There were failed and/or broken API and E2E tests.

---

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

[github-actions[bot]]

Hi @Konamiman,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like: https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[lsinger]

@senadir could you provide testing instructions?

[barryhughes]

A note that this doesn't seem to be reflected in the current CLDR data, which is the standard we follow and generally tell contributors we need to adhere to.

[senadir]

Hey @lsinger, sure, I will add testing steps for WP Admin, Checkout, and Shipping settings.

@barryhughes Thank you for that resource, in that regard, I will a PR there first.

The new system isn't highly enforced now (most shipping companies will still route to the correct place if you provide the city and state, and that' required in shipping), but this is very much in law.

[senadir]

Hey @barryhughes I tried to figure out the contribution process to CLDR and it's confusing at best, and undoable at worse.

[wavvves]

Hey @barryhughes I tried to figure out the contribution process to CLDR and it's confusing at best, and undoable at worse.

Should we wait for that for the review? Maybe add a blocked label? 🤔

[barryhughes]

Hey @barryhughes I tried to figure out the contribution process to CLDR and it's confusing at best, and undoable at worse.

Very belated follow-up here.

Some changes like this are potentially sensitive, depending on the geography, which is why we defer to CLDR (it acts as a sort of neutral authority, but this really only works if we are consistent and don't make exceptions). However, it does seem to have significant 'lag' and, I guess, it sounds like contributing to it is harder than one might expect.

• We don't want to act as gatekeepers here, but perhaps our use of CLDR as the authority for changes like this is something we should start a discussion about?
• In the future, we'd love to get to a point where CLDR data is ingested automatically, perhaps at build-time, rather than using it as a manual reference (which is basically what happens currently).
• We've also discussed making it much easier for merchants to customize this data, so they don't need to resort to code snippets. That might make it more palatable to continue defaulting to CLDR.