woocommerce-ios icon indicating copy to clipboard operation
woocommerce-ios copied to clipboard

[Moooore IPP] Redirect Simple Payments from Order navigation to HubMenu

Open iamgabrielma opened this issue 1 year ago • 1 comments

Closes: #7440

TODO:

  • [ ] After updating dependencies podfile.lock has changed. Confirm why.

Description

Testing instructions

  1. Go to Orders > Tap "+" > Tap "Simple Payments" > See the new bottom sheet appear.
  2. Tap in "Got it!" > Confirm you're redirected to the HubMenu

Screenshots


  • [ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

iamgabrielma avatar Aug 10 '22 16:08 iamgabrielma

You can test the changes from this Pull Request by:

  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr7452-88b9252 on your iPhone
If you need access to App Center, please ask a maintainer to add you.

wpmobilebot avatar Aug 10 '22 16:08 wpmobilebot

The action looks good to me! I just added a couple of small code remarks. :) Besides that, it seems to me that the implemented layout does not fully match the design attached to the issue. Please take a look at this annotated screenshot, you can ask designers for full feedback :)

Annotation on 2022-08-12 at 16-43-56

toupper avatar Aug 12 '22 14:08 toupper

Besides that, it seems to me that the implemented layout does not fully match the design attached to the issue.

Oh, you're right! I didn't see we have a Figma design for the i1 version so I implemented the layout by eye following the gif 😅 I've fixed the view following the design, changes at c0cd8027bfa5e2298ced6f8f1ca98ffe619fd3e2 .

Here are the new screenshots:

Light Mode Dark Mode

iamgabrielma avatar Aug 14 '22 10:08 iamgabrielma

Warnings
:warning: This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by :no_entry_sign: dangerJS

peril-woocommerce[bot] avatar Aug 15 '22 09:08 peril-woocommerce[bot]