woocommerce-ios icon indicating copy to clipboard operation
woocommerce-ios copied to clipboard

[Mobile Payments] Hide IPP Settings

Open toupper opened this issue 1 year ago • 1 comments

Closes: #7363

Description

With this PR we hide the IPP Settings if the "payments in hub menu" feature flag is enabled. The reason behind is that we already have the settings in the newly added Menu section "Payments", so we do not need it to be duplicated. We also have a future task to remove the feature flag and the code behind that: https://github.com/woocommerce/woocommerce-ios/issues/7367. Within the scope of this one we will remove the non-necessary code.

Testing instructions

You can enable/disable the paymentsHubMenuSection feature flag in this line

Feature Flag enabled

  1. Go to Menu
  2. Tap on Settings Action
  3. In-Person Payments row should not be visible

Feature Flag disabled

  1. Go to Menu
  2. Tap on Settings Action
  3. In-Person Payments row should be visible

Screenshots

See above


  • [X] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

toupper avatar Aug 10 '22 14:08 toupper

You can test the changes from this Pull Request by:

  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr7450-5bb962a on your iPhone
If you need access to App Center, please ask a maintainer to add you.

wpmobilebot avatar Aug 10 '22 15:08 wpmobilebot