woocommerce-ios icon indicating copy to clipboard operation
woocommerce-ios copied to clipboard

Experiments framework: add a build script to copy GoogleService-Info.plist from mobile secrets to built directory

Open jaclync opened this issue 3 years ago • 3 comments

Part of #7397 Preparation for Firebase integration for AB testing Platform request: pdnsEh-wr-p2

Description

In order to integrate Firebase to the Experiments framework for AB testing, a GoogleService-Info.plist is required to configure Firebase on app launch. Since this plist file contains confidential information, we want to copy the file from the mobile secrets repo similar to the setup in WCAndroid.

Please excuse the diffs on the ABTest file move, it was a simple folder reorganization but I can reset those diffs manually if it makes review easier.

Testing instructions

Feel free to test the initial integration from https://github.com/woocommerce/woocommerce-ios/pull/7398:

  • Check out the branch in https://github.com/woocommerce/woocommerce-ios/pull/7398
  • Place the GoogleService-Info.plist file in pdnsEh-wr-p2 to .configure/woocommerce-ios/secrets directory on your local machine; if the file has been added to mobile-secrets, try pulling the latest changes in the mobile-secrets repo and then run bundle exec fastlane run configure_apply in WCiOS to get the plist
  • Reinstall the app if needed so that login onboarding is shown
  • Launch the app and log out if needed --> a login onboarding screen should be shown, and a message should be logged in the console: Login onboarding variation: control or Login onboarding variation: treatment(Optional("survey")) along with other Firebase configuration messages

  • [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

jaclync avatar Aug 02 '22 08:08 jaclync

Fails
:no_entry_sign: Podfile: reference to a commit hash

Generated by :no_entry_sign: dangerJS

peril-woocommerce[bot] avatar Aug 02 '22 08:08 peril-woocommerce[bot]

You can test the changes from this Pull Request by:

  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr7396-4f8041a on your iPhone
If you need access to App Center, please ask a maintainer to add you.

wpmobilebot avatar Aug 02 '22 08:08 wpmobilebot

@woocommerce/owl-team There was a Peril error on Podfile: reference to a commit hash but there are no diffs on the Podfile 🤔 any pointers?

jaclync avatar Aug 02 '22 08:08 jaclync

Closing this for now, reasons at pdnsEh-wr-p2#comment-1032

jaclync avatar Aug 12 '22 07:08 jaclync