woocommerce-ios icon indicating copy to clipboard operation
woocommerce-ios copied to clipboard

Published 20 hours ago • verified publisher icon woocommerce

Prevent crash in waitFor tests helper

Open ealeksandrov opened this issue 2 years ago • 2 comments

Forced unwrap in https://github.com/woocommerce/woocommerce-ios/blob/9d2b95a0aecaf8948eec8fa3e3c74c8c345e5205/TestKit/Sources/TestKit/XCTestCase%2BWait.swift#L94 breaks workflow when running unit tests. It should be handled gracefully to allow single test to fail while continuing execution.

image

Possible options:

  1. Return optional value.
  2. Add XCTUnwrap call and throws declaration.

Discussion ref: p1656489779319029-slack-C6H8C3G23

ealeksandrov avatar Jun 29 '22 08:06 ealeksandrov

Fails
:no_entry_sign: Please add a type label to this issue. e.g. 'type: enhancement'
:no_entry_sign: Please add a feature label to this issue. e.g. 'feature: stats'

Generated by :no_entry_sign: dangerJS

peril-woocommerce[bot] avatar Jun 29 '22 08:06 peril-woocommerce[bot]

Fails
:no_entry_sign: Please add a type label to this issue. e.g. 'type: enhancement'
:no_entry_sign: Please add a feature label to this issue. e.g. 'feature: stats'

Generated by :no_entry_sign: dangerJS

peril-woocommerce[bot] avatar Jun 29 '22 08:06 peril-woocommerce[bot]