woocommerce-ios
woocommerce-ios copied to clipboard
Localization and screenshots tooling upgrade: Next steps
trafficstars
This issue pulls together the threads from three PRs I opened recently, because I can benefit from having them all on one place and to avoid missing anything.
The PRs are:
- https://github.com/woocommerce/woocommerce-ios/pull/6936
- https://github.com/woocommerce/woocommerce-ios/pull/6937
- https://github.com/woocommerce/woocommerce-ios/pull/6939
Next Steps
- [x] @mokagio to revert the
download_app_store_translationsdeletion from #6939, because it turns out is not unused as I initially thought - [x] @mokagio to close #6937 for the moment, because it's too simplistic and more work on that area of the code will be required later
- [x] @mokagio to address this comment from #6936 to put it in a ready to merge state – Done
- [ ] Once #6936 is merged: @mokagio / @rachelmcr to coordinate on the screenshots localization tooling updates (see https://github.com/woocommerce/woocommerce-ios/pull/6936#discussion_r881870941)
- [x] Unrelated, but still worth tracking here: @mokagio to remove all the remaining localization scripts that merging #6936 made unused – WIP https://github.com/woocommerce/woocommerce-ios/pull/7032
I opted for an issue over a GitHub project because the latter seemed like too much overhead for the handful of steps we have here.
| Fails | |
|---|---|
| :no_entry_sign: | Please add a type label to this issue. e.g. 'type: enhancement' |
| :no_entry_sign: | Please add a feature label to this issue. e.g. 'feature: stats' |
Generated by :no_entry_sign: dangerJS