[Woo POS] Reader modal should dismiss after connected state changes in Totals View
Describe the bug
Feedback: p91TBi-bYt-p2#comment-12903
On the iOS Errors video there is a flash where the modal closes but the error is still showing. We need to reverse that so the error goes away and then the modal closes.
https://github.com/user-attachments/assets/a1ec9b37-2ea8-4f27-87b1-601875cc25ec
Considerations
We may be only seeing a slight delay since totals view animates transitions.
To Reproduce Steps to reproduce the behavior:
- Open POS
- Add a product
- Check out
- Connect reader
- Notice when reader modal dismisses, totals view transitions into connected state
Expected behavior A clear and concise description of what you expected to happen.
Isolating the problem (mark completed items with an [x]):
- [x] I have deactivated other plugins and confirmed this bug occurs when only WooCommerce plugin is active.
- [x] This bug happens with a default WordPress theme active, or Storefront.
- [x] I can reproduce this bug consistently using the steps above.
Mobile Environment Please include:
- Device:
- iOS version:
- WooCommerce iOS version:
WordPress Environment
Thanks for reporting! 👍
As described, and with our existing code, this will require an artificial delay before we dismiss the connection modal, and even that is likely to take a while to implement.
Showing the connection modals at all is a intermediate point on the road to the preferred design. My understanding is that we'd like them to show in-line in this context, i.e. where the "Connect your reader" error is right now. That would make this a non-issue.
I'm hesitant to spend a long time on this for a relatively infrequent flow, but we could potentially add a new in-line screen that shows behind the connection modals once we start connecting to a reader with Connecting .... If the connection fails or gets cancelled, we'd have to go back to the Reader disconnected view here, after all.
Thanks for taking a look 👍
we could potentially add a new in-line screen that shows behind the connection modals once we start connecting to a reader with Connecting ...
If we are to do something about this, it does sound like a good idea. Although I'm hesitant to spend much time on this as well. It's good to gather feedback but we could leave it with a lower-priority for now.
@staskus Is this still a valid issue? If it is, could you please assign a priority and move it to our backlog, otherwise, close it please. Thanks!
@malinajirka I think this doesn't even deserve a low priority or is not an issue.
I tested it again. Right now with animations, we have two simultaneous events happening after the reader is connected:
- Card Modal animating away
- Checkout View animating to "Checking Order"