woocommerce-ios icon indicating copy to clipboard operation
woocommerce-ios copied to clipboard

Published 20 hours ago • verified publisher icon woocommerce

[Woo POS] UI: CurrencyFormatter usage

Open iamgabrielma opened this issue 9 months ago • 2 comments

UI-wise, we can start applying the different currencies via the existing CurrencyFormatter. While most of it is already in WooFoundation, there's some code and dependencies scattered through different frameworks. At the moment:

  • WooFoundation: CurrencyFormatter
  • WooFoundation: CurrencySettings
  • WooFoundation: CurrencyCode
  • WooFoundation: CurrencyPosition
  • Yosemite: Order+CurrencyFormattedValues
  • WooCommerce: CurrencyFormatterTests

Regarding tests, should we duplicate those in the POS framework as well? I'm not quite sure the WooFoundation framework needs its own testing target for the moment but if we end splitting the pos then it could be the case.

iamgabrielma avatar May 13 '24 04:05 iamgabrielma

Thanks for reporting! 👍

dangermattic avatar May 13 '24 04:05 dangermattic

This task seems to be affected by the uncertainty of keeping POS in a framework pfoUAQ-EF-p2#comment-517.

jaclync avatar May 13 '24 08:05 jaclync

Closed via #12819

iamgabrielma avatar May 28 '24 06:05 iamgabrielma