woocommerce-blocks
woocommerce-blocks copied to clipboard
woocommerce
Slider of Price filter block should use currentColor instead of a hard-coded color
Describe the bug
When the Price filter block is added on a dark background, the slider can't be seen.
To reproduce
- Add the Filter by Price and All Products blocks inside a Columns block into a post or page.
- Change the background color of the Filter by Price column to a dark color. Change the text color to a light color.
- Notice the price slider is no longer visible.
Expected behavior
That's because we have some hard-coded styles in the slider. Ideally, we should default to currentColor.
Screenshots
Sure, go for it, @EmptySet-Exe! You will probably need to look into this CSS file: woocommerce-blocks/assets/js/base/components/price-slider/style.scss.
You can read how to build the project and contribute to it in the Getting Started guide. Let us know if you have any questions and thanks for your effort!
Yes, you can posts your questions here and we will do our best to answer all your questions. :slightly_smiling_face:
Hey I was wondering if you can help me with a hosting issue that I have?
Hi, I'm having trouble viewing my changes in the style.scss show up in my WordPress instance.
Hey I've noticed that the WooCommerce Blocks don't appear in the WP Editor unless if I have the WooCommerce Plugin installed. That's to say that the WooCommerce Blocks don't show up in the Block Inserter if I only have the WooCommerce Block Plugin installed alone. Is that how it's supposed to be, because I can't ensure that my changes are directly appearing on the webpage otherwise.
Hey I've noticed that the WooCommerce Blocks don't appear in the WP Editor unless if I have the WooCommerce Plugin installed. That's to say that the WooCommerce Blocks don't show up in the Block Inserter if I only have the WooCommerce Block Plugin installed alone. Is that how it's supposed to be, because I can't ensure that my changes are directly appearing on the webpage otherwise.
Follow these steps for configuring your local env.
Excuse me, I wanted to know if there are any guidelines for crafting a pull request?
Excuse me, I wanted to know if there are any guidelines for crafting a pull request?
In this folder, there are all the guidelines for the contributors. When you open the PR, you will see a template, just fill the sections and open the PR :)
Hi! It seems that you created the PR https://github.com/woocommerce/woocommerce-blocks/pull/7278. Thanks for working on this! I will take a look in the next few days!
Hey, just curious, can you give me an idea as to why my contribution had failed some of those tests?
Hi @EmptySet-Exe! We have some problems with our current E2E tests, so don't worry about that. Instead, could you fix the CSS linting issue? (https://github.com/woocommerce/woocommerce-blocks/pull/7278#issuecomment-1267115947)