woocommerce-blocks icon indicating copy to clipboard operation
woocommerce-blocks copied to clipboard

Coupons DELETE should return the full cart

Open sitver opened this issue 2 years ago • 0 comments

For the Store API: Right now, deleting a single coupon returns the full cart (as do most cart actions), but deleting all coupons just returns an empty array. It's no big deal, but it would seem to make more sense just to return the whole cart when you delete all coupons, so behaviour is consistent.

sitver avatar Aug 10 '22 16:08 sitver

Thank you for reporting that @sitver, I've made a draft PR to address this issue, you can find it here: https://github.com/woocommerce/woocommerce-blocks/pull/6880

However, this is unlikely to get merged as it is a breaking change, unfortunately. I'll discuss it with my team.

sunyatasattva avatar Aug 11 '22 01:08 sunyatasattva

Internal conversation p1660195800385199-slack-C02UBB1EPEF

ralucaStan avatar Aug 12 '22 09:08 ralucaStan