woocommerce-blocks icon indicating copy to clipboard operation
woocommerce-blocks copied to clipboard

Open T&C and Privacy Policy in new Tab

Open masteradhoc opened this issue 3 years ago • 0 comments

Describe the bug

We should open the pages T&C and Privacy Policy on the checkout in a new tab. Currently these links are set without target blank, see image

Although i found some intention here: https://github.com/woocommerce/woocommerce-blocks/blob/f9ecff2307d5b43afdc8ae3f97011e460a0529fe/assets/js/base/components/cart-checkout/policies/index.tsx#L25

To reproduce

Steps to reproduce the behavior:

  1. Set T&C and Data Protetion Page in Woo /wp-admin/admin.php?page=wc-settings&tab=advanced
  2. set Data Protetion Page in Wordpress /wp-admin/options-privacy.php
  3. Go to Checkout
  4. Click on the link

Expected behavior

Should open both links in a new tab

masteradhoc avatar Aug 04 '22 11:08 masteradhoc

Hey, this is currently possible since those links are regular Gutenberg links, you can just click on them and edit them: image

senadir avatar Aug 15 '22 11:08 senadir

@senadir yes true :) But on the old Checkout they used to be open in a new tab by default. This now doesnt seem the case anymore. From a UX Point of view i think open in a new tab should still be the default and i'd like to reopen the issue and get it back to the previous state.

What do you think?

masteradhoc avatar Aug 16 '22 06:08 masteradhoc

You raise a good point @masteradhoc, I opened a PR to fix that.

senadir avatar Aug 16 '22 09:08 senadir