woocommerce-blocks icon indicating copy to clipboard operation
woocommerce-blocks copied to clipboard

Milestone should be assigned to PRs when they are merged, not when they are approved

Open Aljullu opened this issue 2 years ago • 2 comments

In https://github.com/woocommerce/automations/pull/41 we added an automation to automatically assign the milestone to a PR once it's approved. However, it would be better to assign it once the PR is merged. The main reason is that PRs might be approved, but they might not be ready for release yet (ie: there are conflicts, the PR needs to be released with a pairing PR, the PR was pre-approved but there are still changes needed, etc.).

This issue is about updating the automation so PRs are assigned to the next milestone when and only when they are merged into trunk.

Aljullu avatar Jun 06 '22 09:06 Aljullu

I think either team could work on this one but I see you've assigned it to Kirigami Backlog so will let you guys handle it :) If you need a hand with it let us know

alexflorisca avatar Jun 09 '22 08:06 alexflorisca

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

github-actions[bot] avatar Aug 08 '22 09:08 github-actions[bot]

Closing due to pca54o-6Dz-p2

mikejolley avatar Nov 20 '23 14:11 mikejolley