woocommerce-android icon indicating copy to clipboard operation
woocommerce-android copied to clipboard

Published 20 hours ago • verified publisher icon woocommerce

Removed redundant `setHasOptionsMenu` usage FeedbackCompletedFragment and FeedbackSurveyFragment

Open kidinov opened this issue 3 years ago • 1 comments

Closes: #7345 Closes: #7346

Description

Removes redundant usage of setHasOptionsMenu methods

Testing instructions

  • Change in FeedbackPrefs to
    val userFeedbackIsDue: Boolean
        get() = true
  • Open my store screen
  • Click on `Could be better
  • Notice that the menu has not changed
  • Fill the survey
  • Notice that the menu has not changed on the next screen

Images/gif

before and after

image image image image
  • [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

kidinov avatar Sep 05 '22 12:09 kidinov

You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code:

wpmobilebot avatar Sep 05 '22 12:09 wpmobilebot