woocommerce-android icon indicating copy to clipboard operation
woocommerce-android copied to clipboard

Update androidX.fragment to 2.5.1 replace deprecated onPrepareOptionsMenu, setHasOptionsMenu, onOptionsItemSelected methods

Open kidinov opened this issue 3 years ago • 2 comments
trafficstars

Use parent branch: feature/fix-deprecated-options-menu-calls

Pick one or more fragments from the list and replace deprecated methods usage:

  • onPrepareOptionsMenu
  • setHasOptionsMenu
  • onOptionsItemSelected
  • [x] InfoScreenFragment #7266
  • [x] UserEligibilityErrorFragment #7268
  • [x] #7336
  • [x] #7337
  • [ ] #7345
  • [ ] #7346
  • [x] #7348
  • [x] #7353
  • [x] #7357
  • [x] #7358
  • [ ] #7368
  • [x] #7370
  • [ ] #7372
  • [ ] #7373
  • [ ] #7412
  • [ ] #7414
  • [x] #7415
  • [ ] #7416
  • [x] #7417
  • [x] #7419
  • [ ] #7420
  • [x] #7421
  • [x] #7422
  • [x] #7424
  • [x] #7425
  • [ ] #7426
  • [ ] #7432
  • [x] #7433
  • [x] #7434
  • [ ] #7436
  • [ ] #7437
  • [ ] #7438
  • [ ] #7439
  • [ ] AddOrderShipmentTrackingFragment
  • [ ] AddOrderTrackingProviderListFragment
  • [ ] ReceiptPreviewFragment
  • [ ] SimplePaymentsCustomerNoteFragment
  • [ ] MainSettingsFragment
  • [ ] ProductDetailFragment
  • [ ] ProductFilterListFragment
  • [ ] ProductImageViewerFragment
  • [ ] ProductImagesFragment
  • [ ] ProductListFragment
  • [ ] ProductSelectionListFragment
  • [ ] AddProductCategoryFragment
  • [ ] AddProductCategoryFragment
  • [ ] ParentCategoryListFragment
  • [ ] ProductDownloadDetailsFragment
  • [ ] ProductDownloadsFragment
  • [ ] ProductCatalogVisibilityFragment
  • [ ] ProductVisibilityFragment
  • [ ] VariationDetailFragment
  • [ ] VariationListFragment
  • [ ] VariationsBulkUpdatePriceFragment
  • [ ] AddAttributeFragment
  • [ ] AddAttributeTermsFragment
  • [ ] AttributeListFragment
  • [ ] ReviewListFragment
  • [ ] InstallWCShippingFragment

kidinov avatar Aug 17 '22 10:08 kidinov

Fails
:no_entry_sign: Please add a type label to this issue. e.g. 'type: enhancement'
:no_entry_sign: Please add a feature label to this issue. e.g. 'feature: stats'

Generated by :no_entry_sign: dangerJS

peril-woocommerce[bot] avatar Aug 17 '22 10:08 peril-woocommerce[bot]

Deprecated
androidx.activity.ComponentActivity now implements MenuHost, an interface that allows any component, including your activity itself, to add menu items by calling addMenuProvider(MenuProvider) without forcing all components through this single method override. As this provides a consistent, optionally Lifecycle -aware, and modular way to handle menu creation and item selection, replace usages of this method with one or more calls to addMenuProvider(MenuProvider) in your Activity's onCreate(Bundle) method, having each provider override MenuProvider.onCreateMenu(Menu, MenuInflater) to create their menu items.
Deprecated
This method is no longer needed when using a MenuProvider to provide a Menu to your activity, which replaces onCreateOptionsMenu as the recommended way to provide a consistent, optionally Lifecycle-aware, and modular way to handle menu creation and item selection.
Deprecated
androidx.activity.ComponentActivity now implements MenuHost, an interface that allows any component, including your activity itself, to add menu items by calling addMenuProvider(MenuProvider) without forcing all components through this single method override. Each MenuProvider then provides a consistent, optionally Lifecycle-aware, and modular way to handle menu item selection for the menu items created by that provider. Replace usages of this method with one or more calls to addMenuProvider(MenuProvider) in your Activity's onCreate(Bundle) method, delegating menu item selection to the individual MenuProvider that created the menu items you wish to handle.

There are many of these warnings so maybe split this in several PRs

kidinov avatar Aug 17 '22 10:08 kidinov