woocommerce-android
woocommerce-android copied to clipboard
Project: Mooooore IPP
trafficstars
This is a feature branch to run the final tests before merging to the trunk. All the changes have been reviewed before
https://user-images.githubusercontent.com/4923871/183823162-ea6aa167-ca65-4abe-834d-2dc9fba8aff9.mp4
You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code:
| Fails | |
|---|---|
| :no_entry_sign: |
Danger failed to run |
| Messages | |
|---|---|
| :book: |
This PR contains changes to Tracks-related logic. Please ensure the following are completed: PR Author
|
Error TypeError
Cannot read property 'diffForFile' of undefined
TypeError: Cannot read property 'diffForFile' of undefined
at Object.exports.default (/app/danger-0.33gldha24nz.ts:27:46)
at process._tickCallback (internal/process/next_tick.js:68:7)
Dangerfile
22| // Calculate the changes to Test files because we don't want to limit those
23| // Note that linesOfCode() function in the latest GitDSL can solve this problem in a more elegant way,
24| // but the version of Danger currently used by Peril doesn't have it yet.
25| const testFiles = [...modifiedFiles, ...createdFiles, ...deletedFiles].filter((path: string) => path.includes("/src/test"));
26| let changesToTests = 0;
------------------------------------------------^
27| for (let file of testFiles) {
28| const stringDiffs = await danger.git.diffForFile(file)
29| const addedLines = stringDiffs.added.split("\n").filter(x => x.startsWith("+")).length;
30| const removedLines = stringDiffs.removed.split("\n").filter(x => x.startsWith("-")).length;
Generated by :no_entry_sign: dangerJS