woocommerce-android
woocommerce-android copied to clipboard
woocommerce
[Order Details] Show refunded shipping lines in refund summary
⛔️ Awaiting design confirmation: p91TBi-8P0-p2#comment-10438
Refunded shipping is not displayed anywhere on the Order Details screen, nor in the refund details that you can tap through to.
There’s an outstanding issue on Android from last year to add a line for shipping refunds within the Refunded Products section. – @joshheald
The shipping cost is only referred to in the Payments section – so it seems more natural to me that we’d indicate a shipping refund somewhere here, rather than in the products section. maybe “Refunded: 2 products and shipping ––– $33.00”? – @joe-keenan
I think it’s the right place but I also think that we’ll have problems with larger Dynamic Type sizes and some localizations. – @joshheald
For context: p91TBi-8P0-p2#comment-10327
- [ ] Include refunded shipping lines on Order Details
| Fails | |
|---|---|
| :no_entry_sign: | Please add a type label to this issue. e.g. 'type: enhancement' |
| :no_entry_sign: | Please add a feature label to this issue. e.g. 'feature: stats' |
Generated by :no_entry_sign: dangerJS
![peril-woocommerce[bot] avatar](https://avatars.githubusercontent.com/u/473596?v=4 "Published by a pub.dev verified publisher"){kind=small}
@kidinov In case you've not started yet, I'd avoid working on this one until we get confirmation of the design. I think it will have to change because of localization/dynamic type issues as per p91TBi-8P0-p2#comment-10438
@joshheald oops, I just noticed that after I raised a PR =(. But it's ok, if wording has to be changed it's a small change Btw, I used a bit different (shorter) wording there so we might consider this too
Also, can't you just split the line when it's too long due to a larger font?
Also, can't you just split the line when it's too long due to a larger font?
Yes, it just looks pretty bad and will happen fast on iOS, possibly even at default sizes in some localizations. Here it is forced onto two lines (in code, not due to length or font size.)
Done so far this way - https://github.com/woocommerce/woocommerce-android/pull/6721