woocommerce-android icon indicating copy to clipboard operation
woocommerce-android copied to clipboard

[Woo POS] Entry point won't appear unless restart of the app

Open kidinov opened this issue 1 year ago • 5 comments

Closes: #12740

Description

We fetch remote FF only on the app starts, so the cases when:

  • FF rules contain account restrictions
  • FF rules contain site restrictions are not handled properly on our side and a user has to restart the app.

The change is here to fetch FF on the site change to address that

Steps to reproduce

  • On the clean build login with an account that whitelisted for POS
  • Notice that POS is not shown in the MORE menu unless you restart the app

Testing information

The tests that have been performed

^

  • [x] I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • [x] The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • [x] Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • [x] Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

kidinov avatar Oct 02 '24 12:10 kidinov

1 Warning
:warning: This PR is assigned to the milestone 21.0. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by :no_entry_sign: Danger

dangermattic avatar Oct 02 '24 12:10 dangermattic

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit58b9a491dbb0c51c9edb3690e69ac075eca3280e
Direct Downloadwoocommerce-wear-prototype-build-pr12751-58b9a49.apk

wpmobilebot avatar Oct 02 '24 12:10 wpmobilebot

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit58b9a491dbb0c51c9edb3690e69ac075eca3280e
Direct Downloadwoocommerce-prototype-build-pr12751-58b9a49.apk

wpmobilebot avatar Oct 02 '24 12:10 wpmobilebot

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 40.34%. Comparing base (9c96e74) to head (58b9a49). Report is 18 commits behind head on trunk.

Files with missing lines Patch % Lines
...ain/kotlin/com/woocommerce/android/SiteObserver.kt 75.00% 1 Missing and 1 partial :warning:
.../com/woocommerce/android/util/GetAppVersionName.kt 0.00% 2 Missing :warning:
...n/kotlin/com/woocommerce/android/AppInitializer.kt 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff            @@
##              trunk   #12751   +/-   ##
=========================================
  Coverage     40.34%   40.34%           
- Complexity     5773     5774    +1     
=========================================
  Files          1245     1246    +1     
  Lines         70799    70804    +5     
  Branches       9893     9893           
=========================================
+ Hits          28563    28568    +5     
+ Misses        39604    39603    -1     
- Partials       2632     2633    +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 02 '24 12:10 codecov-commenter

@ThomazFB 👋

Maybe you can point to someone to take a look into this, as we have no expertise in remote FF at all

kidinov avatar Oct 03 '24 15:10 kidinov