woocommerce-android icon indicating copy to clipboard operation
woocommerce-android copied to clipboard

[Order filtering] Filtering orders by product screen contains a filter button that is broken

Open backwardstruck opened this issue 1 year ago • 7 comments

Closes: #12623

Description

Addresses an issue where the filter button on the product selection screen is non-responsive. The problem was due to the navigation action not being correctly recognized.

Steps to reproduce

  1. Go to the Orders tab.
  2. Click on the Filters option.
  3. Select Products from the filter options.
  4. Click the Filter button on the product selection screen.

Expected Behavior:

  • The filter button should open the product selection filter screen with options for stock status, product status, product type, and product category.

Testing information

Devices Used: tablet emulator

Affected Areas:

  • Product Selection Screen

The tests that have been performed

  • Verified the navigation works as expected for the filter button.

  • Ensured dark mode compatibility for the filter screen.

  • Conducted smoke tests to confirm no regressions in navigation flow.

  • [x] I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • [ ] The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • [ ] Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • [ ] Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

backwardstruck avatar Sep 18 '24 22:09 backwardstruck

1 Message
:book: This PR is still a Draft: some checks will be skipped.

Generated by :no_entry_sign: Danger

dangermattic avatar Sep 18 '24 22:09 dangermattic

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit5e7b4caea3f8976d5d2dff68eb795969b53517f5
Direct Downloadwoocommerce-wear-prototype-build-pr12643-5e7b4ca.apk

wpmobilebot avatar Sep 18 '24 22:09 wpmobilebot

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit5e7b4caea3f8976d5d2dff68eb795969b53517f5
Direct Downloadwoocommerce-prototype-build-pr12643-5e7b4ca.apk

wpmobilebot avatar Sep 18 '24 22:09 wpmobilebot

Found 1 violations:

The PR caused the following dependency changes:

expand

-+--- androidx.databinding:viewbinding:8.5.1
++--- androidx.databinding:viewbinding:8.4.0
 +--- project :libs:cardreader
 |    \--- com.stripe:stripeterminal-localmobile:3.7.1
-|         \--- androidx.databinding:viewbinding:8.2.2 -> 8.5.1 (*)
+|         \--- androidx.databinding:viewbinding:8.2.2 -> 8.4.0 (*)
 \--- org.wordpress:mediapicker:0.3.1
-     \--- androidx.databinding:viewbinding:8.1.0 -> 8.5.1 (*)
+     \--- androidx.databinding:viewbinding:8.1.0 -> 8.4.0 (*)

Please review and act accordingly

<this is a auto generated comment from violation-comments-lib F7F8ASD8123FSDF>

<ACCUMULATED-VIOLATIONS>

wpmobilebot avatar Sep 20 '24 21:09 wpmobilebot

Version 20.6 has now entered code-freeze, so the milestone of this PR has been updated to 20.7.

wpmobilebot avatar Sep 27 '24 20:09 wpmobilebot

Version 20.7 has now entered code-freeze, so the milestone of this PR has been updated to 20.8.

wpmobilebot avatar Oct 11 '24 11:10 wpmobilebot

Version 20.8 has now entered code-freeze, so the milestone of this PR has been updated to 20.9.

wpmobilebot avatar Oct 18 '24 11:10 wpmobilebot

Version 20.9 has now entered code-freeze, so the milestone of this PR has been updated to 21.0.

wpmobilebot avatar Oct 25 '24 10:10 wpmobilebot