woocommerce-android
woocommerce-android copied to clipboard
[Order filtering] Filtering orders by product screen contains a filter button that is broken
Closes: #12623
Description
Addresses an issue where the filter button on the product selection screen is non-responsive. The problem was due to the navigation action not being correctly recognized.
Steps to reproduce
- Go to the Orders tab.
- Click on the Filters option.
- Select Products from the filter options.
- Click the Filter button on the product selection screen.
Expected Behavior:
- The filter button should open the product selection filter screen with options for stock status, product status, product type, and product category.
Testing information
Devices Used: tablet emulator
Affected Areas:
- Product Selection Screen
The tests that have been performed
-
Verified the navigation works as expected for the filter button.
-
Ensured dark mode compatibility for the filter screen.
-
Conducted smoke tests to confirm no regressions in navigation flow.
-
[x] I have considered if this change warrants release notes and have added them to
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.
Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:
- [ ] The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
- [ ] Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
- [ ] Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.
| 1 Message | |
|---|---|
| :book: | This PR is still a Draft: some checks will be skipped. |
Generated by :no_entry_sign: Danger
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
| App Name | WooCommerce-Wear Android | |
| Platform | ⌚️ Wear OS | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | 5e7b4caea3f8976d5d2dff68eb795969b53517f5 | |
| Direct Download | woocommerce-wear-prototype-build-pr12643-5e7b4ca.apk |
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
| App Name | WooCommerce Android | |
| Platform | 📱 Mobile | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | 5e7b4caea3f8976d5d2dff68eb795969b53517f5 | |
| Direct Download | woocommerce-prototype-build-pr12643-5e7b4ca.apk |
Found 1 violations:
The PR caused the following dependency changes:
expand
-+--- androidx.databinding:viewbinding:8.5.1
++--- androidx.databinding:viewbinding:8.4.0
+--- project :libs:cardreader
| \--- com.stripe:stripeterminal-localmobile:3.7.1
-| \--- androidx.databinding:viewbinding:8.2.2 -> 8.5.1 (*)
+| \--- androidx.databinding:viewbinding:8.2.2 -> 8.4.0 (*)
\--- org.wordpress:mediapicker:0.3.1
- \--- androidx.databinding:viewbinding:8.1.0 -> 8.5.1 (*)
+ \--- androidx.databinding:viewbinding:8.1.0 -> 8.4.0 (*)
Please review and act accordingly
<this is a auto generated comment from violation-comments-lib F7F8ASD8123FSDF>
<ACCUMULATED-VIOLATIONS>
Version 20.6 has now entered code-freeze, so the milestone of this PR has been updated to 20.7.
Version 20.7 has now entered code-freeze, so the milestone of this PR has been updated to 20.8.
Version 20.8 has now entered code-freeze, so the milestone of this PR has been updated to 20.9.
Version 20.9 has now entered code-freeze, so the milestone of this PR has been updated to 21.0.