woocommerce-android
woocommerce-android copied to clipboard
[Bug] in landscape marking as paid with cash keeps user on collect payment screen
Closes: #11661
Slack discussion.
Description
Addresses the issue where marking an order as paid with cash when switching from landscape mode to single pane mode keeps the user on the collect payment screen instead of redirecting them to the order list.
Problem: When the device is in landscape mode, marking an order as paid via cash completes the operation behind the scenes, but the user remains on the collect payment screen.
Steps to reproduce
- Create a new order and add a product or custom amount.
- Tap on 'Collect Payment'.
- Rotate the device to landscape mode/change to split screen mode if on a tablet.
- Tap 'Cash' and then tap 'Mark as Paid'.
- Verify that you are redirected to the order list instead of remaining on the collect payment screen.
Alternate steps that @samiuelson and I discovered (seems to be the same underlying issue):
- Create a new order and add a product or custom amount.
- Tap on 'Collect Payment'.
- Rotate the device to landscape mode/change to split screen mode if on a tablet.
- Tap the back button.
- Verify that you are redirected to the order detail screen.
Testing information
- Devices Tested: phone and tablet emulators
- Scenarios Tested:
- Creating a new order and marking it as paid in both portrait and landscape modes.
- Ensuring the correct navigation flow from the collect payment screen to the order list.
The tests that have been performed
-
Verified the navigation flow in both portrait and landscape modes.
-
Ensured no regressions in the collect payment screen.
-
[x] I have considered if this change warrants release notes and have added them to
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.
Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:
- [ ] The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
- [ ] Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
- [ ] Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.
| 1 Message | |
|---|---|
| :book: | This PR is still a Draft: some checks will be skipped. |
Generated by :no_entry_sign: Danger
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
| App Name | WooCommerce-Wear Android | |
| Platform | ⌚️ Wear OS | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | ab03fd1ea249370b1d9b91c9909c876e4d6027df | |
| Direct Download | woocommerce-wear-prototype-build-pr12632-ab03fd1.apk |
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
| App Name | WooCommerce Android | |
| Platform | 📱 Mobile | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | ab03fd1ea249370b1d9b91c9909c876e4d6027df | |
| Direct Download | woocommerce-prototype-build-pr12632-ab03fd1.apk |