woocommerce-android
woocommerce-android copied to clipboard
Fix Print Shipping Label Navigation Issue
Closes: #10924
Description
When you go through the flow of purchasing a shipping label and you print it and you are pressing back to go to the order details you would be taken to the home screen i.e My Store. This PR fixes this issue so you are taken to order details.
Testing instructions
Verify the below on tablets and phones. I have noticed inconsistencies with this navigation when used on either device before this fix.
For these tests it is recommended to do the flows below on trunk for both phones and tablets to see the behavior of the app before switching to this branch.
Printing
- Go to an Order that is eligible for shipping labels.
- Go through the flow to the purchased label being printed.
- Attempt to press back to go back to order details.
- Notice you end up on order details.
Reprint
- Go to an Order that has a shipping label that has been printed already.
- Go to the print the order.
- Press back to go back to order details.
- Notice you end up there.
Images/gif
The bug that is taking place on Tablets
Printing Flow
Reprinting Flow
- [x] I have considered if this change warrants release notes and have added them to
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.
I am trying to figure out the best way to rotate the webm output from emulates @samiuelson Let me know if you have done it already. I will check it out in the morning.
I was going to write a ffmpeg script to rotate it but I am wondering if I am overthinking it 😅 maybe I can just do it in HTML
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
| App Name | WooCommerce Android | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | 5ec4ed623e4cbcad42de01beedd589698e8f9bb6 | |
| Direct Download | woocommerce-prototype-build-pr10933-5ec4ed6.apk |
@jd-alexander 👋
I am trying to figure out the best way to rotate the webm output from emulates @samiuelson Let me know if you have done it already. I will check it out in the morning.
The emulator has a button to record a video (or you use that and it records it vertically?), or you can just use the script (that's how I do that)
https://github.com/kidinov/adb-video-recording
I noticed a small bug here, not related to the PR:
- For some reason, the first order is reselected when I go back with the system button (not really related to the PR, though)
https://github.com/woocommerce/woocommerce-android/assets/4923871/232947b5-24ba-4458-b4bc-b543339459ff
Regarding the PR itself - did you check it with the system back button? In my case I had to do extra steps to make it work properly - https://github.com/woocommerce/woocommerce-android/pull/11022/files#diff-476346ed4a88681fdb690133ded7b4c89afb2a8b41100f7975f375180eb319fc
And btw, I could not test the PR as I don't know how to simulate a purchase. Would you mind quickly sharing an instruction with me (if needed privately)? Thanks!
Thanks for the feedback. I am going to do some testing and then provide further instructions on how to get the flow tested.