woocommerce-android icon indicating copy to clipboard operation
woocommerce-android copied to clipboard

[Tablet support M3] Part 4 – Order summary product buttons update

Open samiuelson opened this issue 1 year ago • 2 comments

Closes: #10618

Description

This PR adjusts the appearance of the products section's buttons in tablet mode:

  • "+ Add products" button is visible only on a phone. On tablet, the product selector is open all the time, so it's redundant.
  • "Scan products" is visible as an icon on the phone and a full button on the tablet.

Testing instructions

Verify that the buttons are shown correctly on tablet and phone.

Images/gif

Tablet Phone
  • [x] I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

samiuelson avatar Feb 19 '24 16:02 samiuelson

1 Error
:no_entry_sign: This PR is tagged with status: do not merge label(s).

Generated by :no_entry_sign: Danger

dangermattic avatar Feb 19 '24 16:02 dangermattic

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commitecf314ff9f67be339a649948735f2a3825141260
Direct Downloadwoocommerce-prototype-build-pr10859-ecf314f.apk

wpmobilebot avatar Feb 19 '24 16:02 wpmobilebot

I did a first pass on the PR. I will have another review tomorrow.

jd-alexander avatar Feb 22 '24 04:02 jd-alexander

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.26%. Comparing base (37270cb) to head (320e4c6). Report is 831 commits behind head on tablet-support-m3-part-3.

:exclamation: Current head 320e4c6 differs from pull request most recent head bd2ad44. Consider uploading reports for the commit bd2ad44 to get more accurate results

Additional details and impacted files
@@                      Coverage Diff                       @@
##             tablet-support-m3-part-3   #10859      +/-   ##
==============================================================
- Coverage                       41.56%   41.26%   -0.31%     
- Complexity                       5009     5063      +54     
==============================================================
  Files                            1010     1029      +19     
  Lines                           58071    59407    +1336     
  Branches                         7735     7957     +222     
==============================================================
+ Hits                            24140    24514     +374     
- Misses                          31786    32718     +932     
- Partials                         2145     2175      +30     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 26 '24 20:02 codecov-commenter