woocommerce-android icon indicating copy to clipboard operation
woocommerce-android copied to clipboard

[Tablet support M3] Part 2 – Toolbar refactoring

Open samiuelson opened this issue 1 year ago • 1 comments

Closes: #10615

Description

This PR refactors toolbar implementation in order creation screen. We are switching from MainActivity AppBarLayout to local Toolbar components to support two-pane screen mode with separate titles, menus and navigation icons.

Testing instructions

  • Create new order and observe new toolbar layout on large screens based on the designs – 6kkCwI9VOEYcidp6UT5bln-fi-192%3A25891

  • On the standard screen, the toolbar should look as before, however, the collapsing app bar layout behavior is removed.

Note that the toolbar of product selector fragment will be removed in the next PR.

Images/gif

https://github.com/woocommerce/woocommerce-android/assets/4527432/0d095fec-6ee9-4876-9ea9-ee27026481fb

  • [x] I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

samiuelson avatar Feb 06 '24 21:02 samiuelson

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commit301149f275b2407f79f9f0473f71b334770bf46d
Direct Downloadwoocommerce-prototype-build-pr10694-301149f.apk

wpmobilebot avatar Feb 06 '24 21:02 wpmobilebot

2 Errors
:no_entry_sign: Please add tests for class DeviceType (or add unit-tests-exemption label to ignore this).
:no_entry_sign: Please add tests for class ProductSelectorSharedViewModel (or add unit-tests-exemption label to ignore this).
1 Warning
:warning: This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by :no_entry_sign: Danger

dangermattic avatar Mar 11 '24 20:03 dangermattic