woocommerce-android
woocommerce-android copied to clipboard
[Tablet support M3] Part 1 – Dynamic layout
[Tablet support M3] Part 1 – Dynamic layout
⚠️ Do not merge this PR, as it serves as the foundational PR for subsequent Order list and Order detail tablet support related PRs.
Closes: https://github.com/woocommerce/woocommerce-android/issues/10614
Description
This PR adds NavHostFragment to the order creation/edition layout. The purpose of the new fragment is to display a two-pane layout on large screens with product selectors on the left and order creation form on the right.
Testing instructions
- Run the app on physical tablet or in a tablet emulator
- Click on the Orders tab and create a new order
- Observe the two-pane layout is present and it adjusts to screen size (e.g. when rotating the screen, or opening split mode)
Images/gif
https://github.com/woocommerce/woocommerce-android/assets/4527432/940ad780-4467-4741-824b-5d1f7226b0f7
- [x] I have considered if this change warrants release notes and have added them to
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.
| 4 Warnings | |
|---|---|
| :warning: | This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews. |
| :warning: | Class DeviceType is missing tests, but unit-tests-exemption label was set to ignore this. |
| :warning: | Class ProductSelectorSharedViewModel is missing tests, but unit-tests-exemption label was set to ignore this. |
| :warning: | This PR is assigned to the milestone 17.8. The due date for this milestone has already passed. Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished. |
Generated by :no_entry_sign: Danger
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
| App Name | WooCommerce Android | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | 2f5f3f003b42b7219c70962c203608f57644d881 | |
| Direct Download | woocommerce-prototype-build-pr10683-2f5f3f0.apk |
Codecov Report
Attention: Patch coverage is 42.85714% with 64 lines in your changes are missing coverage. Please review.
Project coverage is 41.88%. Comparing base (
e65e448) to head (2f5f3f0). Report is 109 commits behind head on trunk.
Additional details and impacted files
@@ Coverage Diff @@
## trunk #10683 +/- ##
============================================
- Coverage 41.88% 41.88% -0.01%
- Complexity 5209 5214 +5
============================================
Files 1054 1056 +2
Lines 60680 60771 +91
Branches 8196 8205 +9
============================================
+ Hits 25417 25453 +36
- Misses 32984 33035 +51
- Partials 2279 2283 +4
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.