wc-smooth-generator icon indicating copy to clipboard operation
wc-smooth-generator copied to clipboard

added fees (feature request #69)

Open michi-dev opened this issue 3 years ago • 3 comments

All Submissions:

Changes proposed in this Pull Request:

Closes #69.

"It would be very nice to add some fees to the order. I would add some example fee amounts : $10.00 (fixed) , $100.00 (fixed), $1000.00 (fixed), 10% (percentage), 33% (percentage). I would add it to every (lets say) every 5. order."

  • every 5. order (randomized function so not particular ever 5.) gets a fee
  • the fee is a float between 0.05 and 100 (used https://github.com/fzaninotto/Faker )
  • I just used absolute values -> because you only can insert relative percentages via the graphical interface. After that it will be set as absolute values

How to test the changes in this Pull Request:

  1. use the generall command wp wc generate orders <amount> at least with amount 5
  2. remeber that its random -> so it could depend if its every 5. order

Other information:

  • [X] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ ] Have you written new tests for your changes, as applicable?
  • [X] Have you successfully run tests with your changes locally?

Changelog entry

add fees to orders randomly (every 5. order, fees from 0.05 - 100 in specific currency)

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

FOR PR REVIEWER ONLY:

  • [ ] I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

michi-dev avatar Jan 21 '22 15:01 michi-dev

@rrennick any chance someone of your team can take a look at it anytime next?

masteradhoc avatar May 06 '22 07:05 masteradhoc

@masteradhoc Thanks for the ping. I'm working on a non-Woo project ATM. @ObliviousHarmony Could you follow up here?

rrennick avatar May 09 '22 12:05 rrennick

changes have been done @Luc45

michi-dev avatar Jul 04 '22 05:07 michi-dev

@Luc45 any update on these PR's?

masteradhoc avatar Aug 29 '22 15:08 masteradhoc

I see no reason why we can't merge this. Thanks for this @michi-dev and apologies this has been sitting around so long.

samueljseay avatar Sep 08 '22 21:09 samueljseay