wc-smooth-generator
wc-smooth-generator copied to clipboard
added fees (feature request #69)
All Submissions:
- [x] Have you followed the Contributing guidelines?
- [x] Does your code follow the WordPress' coding standards?
- [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Changes proposed in this Pull Request:
Closes #69.
"It would be very nice to add some fees to the order. I would add some example fee amounts : $10.00 (fixed) , $100.00 (fixed), $1000.00 (fixed), 10% (percentage), 33% (percentage). I would add it to every (lets say) every 5. order."
- every 5. order (randomized function so not particular ever 5.) gets a fee
- the fee is a float between 0.05 and 100 (used https://github.com/fzaninotto/Faker )
- I just used absolute values -> because you only can insert relative percentages via the graphical interface. After that it will be set as absolute values
How to test the changes in this Pull Request:
- use the generall command
wp wc generate orders <amount>at least with amount 5 - remeber that its random -> so it could depend if its every 5. order
Other information:
- [X] Have you added an explanation of what your changes do and why you'd like us to include them?
- [ ] Have you written new tests for your changes, as applicable?
- [X] Have you successfully run tests with your changes locally?
Changelog entry
add fees to orders randomly (every 5. order, fees from 0.05 - 100 in specific currency)
Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.
FOR PR REVIEWER ONLY:
- [ ] I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.
@rrennick any chance someone of your team can take a look at it anytime next?
@masteradhoc Thanks for the ping. I'm working on a non-Woo project ATM. @ObliviousHarmony Could you follow up here?
changes have been done @Luc45
@Luc45 any update on these PR's?
I see no reason why we can't merge this. Thanks for this @michi-dev and apologies this has been sitting around so long.